Bug 1168108 - cli/georep: Geo-rep can't set rsync_options through cli
Summary: cli/georep: Geo-rep can't set rsync_options through cli
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Kotresh HR
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1160790
TreeView+ depends on / blocked
 
Reported: 2014-11-26 07:25 UTC by Kotresh HR
Modified: 2015-05-14 17:45 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of:
Environment:
Last Closed: 2015-05-14 17:28:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kotresh HR 2014-11-26 07:25:24 UTC
Description of problem:
Geo-replication cannot set rsync_options through cli.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
#gluster volume geo-replication master fedora1:slave config rsync-options --bwlimit=100
Fails with --bwlimit as unrecognized option.

Actual results:
Fails with --bwlimit as unrecognized option

Expected results:
geo-rep rsync-options should be allowed to set through cli.

Additional info:

Comment 1 Anand Avati 2014-11-26 07:27:23 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep cmds.) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 2 Anand Avati 2015-04-06 11:26:11 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2015-04-06 11:29:14 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 4 Anand Avati 2015-04-07 04:12:26 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 5 Anand Avati 2015-04-07 04:36:35 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#5) for review on master by Kotresh HR (khiremat)

Comment 6 Anand Avati 2015-04-07 07:34:37 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#6) for review on master by Kotresh HR (khiremat)

Comment 7 Anand Avati 2015-04-07 08:56:34 UTC
REVIEW: http://review.gluster.org/9198 (cli: Allow options prefixed with '--' for geo-rep config cmds) posted (#7) for review on master by Kotresh HR (khiremat)

Comment 8 Anand Avati 2015-04-09 11:37:17 UTC
COMMIT: http://review.gluster.org/9198 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 55ec6f27dd6be71224bb3b0da24c4258596db024
Author: Kotresh HR <khiremat>
Date:   Wed Nov 26 12:35:23 2014 +0530

    cli: Allow options prefixed with '--' for geo-rep config cmds
    
    Geo-replications allows users to send rsync_options from
    cli but while parsing, options prefixed with '--' are
    treated as unrecognized apart from a few options. Because
    of this rsync_options can't be set through cli. This
    patch allows such options if it's a geo-rep config command.
    
    e.g.
    gluster vol geo-rep master fedora1::slave config rsync-options \
    "--bwlimit=1.5m"
    
    Change-Id: I4b4f10c0efd3f3a362ece65e697d5ce1498f84ac
    BUG: 1168108
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/9198
    Reviewed-by: Aravinda VK <avishwan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 9 Niels de Vos 2015-05-14 17:28:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:35:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:38:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:45:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.