Red Hat Bugzilla – Bug 1168480
Should prompt correct information when execute oo-admin-ctl-user --addgearsize $invalid value
Last modified: 2016-03-22 12:51:06 EDT
Description of problem: In broker execute oo-admin-ctl-user -l$usename --addgearsize small,medium or other invalid value, it prompts error info Version-Release number of selected component (if applicable): ose2.2.2/2014-11-24.3 How reproducible: Always Steps to Reproduce: 1.oo-admin-ctl-user -lwyy --addgearsize small,medium Actual results: # oo-admin-ctl-user --addgearsize small,medium -lyanywang Adding gear size small,medium for user yanywang... Size small,medium is not defined. Defined sizes are: small, medium. /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-controller-1.32.3.1/app/models/cloud_user.rb:400:in `add_gear_size' /usr/sbin/oo-admin-ctl-user:380:in `block in add_gear_size' /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-controller-1.32.3.1/app/models/lock.rb:92:in `_run_in_app_user_lock' /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-controller-1.32.3.1/app/models/lock.rb:38:in `run_in_user_lock' /usr/sbin/oo-admin-ctl-user:379:in `add_gear_size' /usr/sbin/oo-admin-ctl-user:728:in `block in <main>' /usr/sbin/oo-admin-ctl-user:653:in `each' /usr/sbin/oo-admin-ctl-user:653:in `<main>' Expected results: ERROR:addgearsize must be one of small or medium Additional info:
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/3327dbdb673981e6ac3295f0bf052a6711375039 oo-admin-ctl-user: clarify error msg Bug 1168480 Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1168480 Clarify oo-admin-ctl-user --addgearsize <invalid name> error msg. Removed the backtrace info from the error msg and updated the error msg. Error msg is now more readable for users.
Seem like the PR is for origin upstream, but not for OSE, right? According to our work flow, QE need verify bug against a OSE errata puddle, I did not found any errata puddle yet, so I change the status to "MODIFIED", only when the PR is merged to OSE code source, and new a errata puddle, then move the bug to "ON_QA".
QE, Can we verify that this is now fixed? 1.oo-admin-ctl-user -lwyy --addgearsize small,medium Should now correctly error and output something like "ERROR:addgearsize must be one of small or medium" Puddle: http://etherpad.corp.redhat.com/puddle-2-2-2016-02-19 Thank you
Verify this bug with puddle 2.2/2016-02-25.2 [root@broker ~]# oo-admin-ctl-user -l gpei --addgearsize medium,large Adding gear size medium,large for user gpei... ERROR: Size 'medium,large' is not defined. Available gear sizes: small, medium, large, small.highcpu. [root@broker ~]# oo-admin-ctl-user -l gpei --addgearsize invalid Adding gear size invalid for user gpei... ERROR: Size 'invalid' is not defined. Available gear sizes: small, medium, large, small.highcpu.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-0489.html