Bug 1168612 - Review Request: perl-List-Pairwise - Map/grep arrays and hashes pairwise
Summary: Review Request: perl-List-Pairwise - Map/grep arrays and hashes pairwise
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1163236
TreeView+ depends on / blocked
 
Reported: 2014-11-27 12:18 UTC by Petr Šabata
Modified: 2014-12-01 14:13 UTC (History)
2 users (show)

Fixed In Version: perl-List-Pairwise-1.03-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-01 14:13:55 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-11-27 12:18:26 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-List-Pairwise/perl-List-Pairwise.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-List-Pairwise/perl-List-Pairwise-1.03-1.fc20.src.rpm
Description:
List::Pairwise provides functions to map and grep lists two elements at a
time, setting $a and $b to each pair instead of setting $_ to each element.
Fedora Account System Username: psabata

Comment 1 Jitka Plesnikova 2014-11-27 14:33:41 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are  almost ok
TODO: Add BRs perl(File::Path): List-Pairwise-1.03/inc/Module/Install.pm:24

$ rpm -qp --requires perl-List-Pairwise-1.03-1.fc22.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.006
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Exporter)
      1 perl(constant)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-List-Pairwise-1.03-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(List::Pairwise) = 1.03
      1 perl-List-Pairwise = 1.03-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-List-Pairwise.spec ./perl-List-Pairwise-1.03-1.fc22.*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' item.

Otherwise package looks good.
Package APPROVED.

Comment 2 Petr Šabata 2014-11-27 14:42:35 UTC
New Package SCM Request
=======================
Package Name: perl-List-Pairwise
Short Description: Map/grep arrays and hashes pairwise
Upstream URL: http://search.cpan.org/dist/List-Pairwise/
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-12-01 13:44:22 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2014-12-01 14:13:55 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.