Bug 1168657
| Summary: | nmcli hangs when deleting profile two times | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> |
| Component: | NetworkManager | Assignee: | Jirka Klimes <jklimes> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 7.2 | CC: | danw, dcbw, jklimes, lrintel, rkhan, thaller, tpelka |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Multiple bugs that could cause the client tools to become unresponsive or terminate unexpectedly have been fixed. (BZ#1168657, BZ#1182575, BZ#1197203)
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-19 10:58:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vladimir Benes
2014-11-27 14:04:40 UTC
The error seems to be in the daemon. nmcli sends too Delete() D-Bus calls, but it doesn't get any response/error for the second. Investigating... I have fixed nmcli not to call delete (or down) for the same connection multiple times. The change is in upstream branch jk/nmcli-con-delete-rh1168657. That will fix the bug. Nevertheless, we still should look into NetworkManager itself to fix the D-Bus responses. (In reply to Jirka Klimes from comment #3) > I have fixed nmcli not to call delete (or down) for the same connection > multiple times. The change is in upstream branch > jk/nmcli-con-delete-rh1168657. That will fix the bug. > > Nevertheless, we still should look into NetworkManager itself to fix the > D-Bus responses. could this hanging be caused libnm? ( https://bugzilla.redhat.com/show_bug.cgi?id=1079353#c41 ) I'd rather have the:
g_signal_handlers_disconnect_by_func (G_OBJECT (connection),
down_active_connection_state_cb,
info);
be done in down_active_connection_state_cb(), since connection_cb_info_finish() is called in two paths, and this disconnect is only relevant in one of them. The other caller of the connection_cb_info_finish() in that path (connection_op_timeout_cb()) passes a NULL connection so the code there wouldn't hit anyway.
The rest looks good.
(In reply to Thomas Haller from comment #4) > (In reply to Jirka Klimes from comment #3) > > I have fixed nmcli not to call delete (or down) for the same connection > > multiple times. The change is in upstream branch > > jk/nmcli-con-delete-rh1168657. That will fix the bug. > > > > Nevertheless, we still should look into NetworkManager itself to fix the > > D-Bus responses. > > could this hanging be caused libnm? ( > https://bugzilla.redhat.com/show_bug.cgi?id=1079353#c41 ) I don't think so. I think it was caused by NM not sending any response to D-Bus call. (In reply to Dan Williams from comment #5) > I'd rather have the: > > g_signal_handlers_disconnect_by_func (G_OBJECT (connection), > down_active_connection_state_cb, > info); > > be done in down_active_connection_state_cb(), since > connection_cb_info_finish() is called in two paths, and this disconnect is > only relevant in one of them. The other caller of the > connection_cb_info_finish() in that path (connection_op_timeout_cb()) passes > a NULL connection so the code there wouldn't hit anyway. > Fixed. Pushed to upstream master as: f52e6bb cli: do not stall in 'nmcli connection delete/down' (rh #1168657) Cherry-picked into nm-1-0: 1203f22 cli: do not stall in 'nmcli connection delete/down' (rh #1168657) No hangs occur anymore. Verified on all supported architectures. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-2315.html |