Bug 1168721 - Review Request: perl-MooseX-App - Write user-friendly command line apps with even less suffering
Summary: Review Request: perl-MooseX-App - Write user-friendly command line apps with ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1168697 1168720
Blocks: 1163236
TreeView+ depends on / blocked
 
Reported: 2014-11-27 16:19 UTC by Petr Šabata
Modified: 2014-12-02 14:44 UTC (History)
3 users (show)

Fixed In Version: perl-MooseX-App-1.30-2.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-02 14:44:15 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-11-27 16:19:27 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-MooseX-App/perl-MooseX-App.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-MooseX-App/perl-MooseX-App-1.30-1.fc20.src.rpm
Description:
MooseX-App is a highly customisable helper to write user-friendly command
line applications without having to worry about most of the annoying things
usually involved. Just take any existing Moose class, add a single line
(use MooseX-App qw(PluginA PluginB ...);) and create one class for each
command in an underlying namespace. Options and positional parameters can
be defined as simple Moose accessors.
Fedora Account System Username: psabata

Comment 1 Jitka Plesnikova 2014-12-02 11:47:30 UTC
Source file is ok
Summary is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

Binary requires/provides was not checked, because build failed.

$ rpmlint ./perl-MooseX-App.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok - only spec file was checked

License is ok
FIX: Build failed, because license file has typo at name - LICENCE
+ cp -pr LICENSE
/builddir/build/BUILDROOT/perl-MooseX-App-1.30-1.fc22.noarch/usr/share/licenses/perl-MooseX-App
cp: cannot stat 'LICENSE': No such file or directory


Unversioned perl(Moose) is required and also filtered.
FIX: Probably should be required perl(Moose) >= 2.00 or did I missed 
anything?

Please correct all 'FIX' issues and provide new spec file.

Package is NOT APPROVED.

Comment 3 Jitka Plesnikova 2014-12-02 13:01:06 UTC
> Source file is ok
> Summary is ok
> Description is ok
> URL and Source0 are ok
> All tests passed
> BuildRequires are ok
  
> License is ok
> FIX: Build failed, because license file has typo at name - LICENCE
> + cp -pr LICENSE
> /builddir/build/BUILDROOT/perl-MooseX-App-1.30-1.fc22.noarch/usr/share/
> licenses/perl-MooseX-App
> cp: cannot stat 'LICENSE': No such file or directory
 @@ -83,3 +83,3 @@
 %files
-%license LICENSE
+%license LICENCE
 %doc Changes README TODO

Fixed.

> Unversioned perl(Moose) is required and also filtered.
> FIX: Probably should be required perl(Moose) >= 2.00 or did I missed 
> anything?
@@ -56,3 +56,3 @@
 Requires:       perl(I18N::Langinfo)
-Requires:       perl(Moose)
+Requires:       perl(Moose) >= 2.00
 
Fixed.

$ rpm -qp --requires perl-MooseX-App-1.30-2.fc22.noarch.rpm | sort | uniq -c
      1 perl >= 1:5.010
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Config::Any)
      1 perl(Encode)
      1 perl(File::HomeDir)
      1 perl(I18N::Langinfo)
      1 perl(IO::Interactive)
      1 perl(List::Util)
      1 perl(Module::Pluggable::Object)
      1 perl(Moose) >= 2.00
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(Moose::Util::TypeConstraints)
      1 perl(MooseX::App::Command)
      1 perl(MooseX::App::Exporter)
      1 perl(MooseX::App::Message::Block)
      1 perl(MooseX::App::Message::BlockColor)
      1 perl(MooseX::App::Message::Envelope)
      1 perl(MooseX::App::Meta::Role::Attribute::Option)
      1 perl(MooseX::App::ParsedArgv)
      1 perl(MooseX::App::ParsedArgv::Element)
      1 perl(MooseX::App::Plugin::BashCompletion::Command)
      1 perl(MooseX::App::Plugin::Man::Command)
      1 perl(MooseX::App::Plugin::Version::Command)
      1 perl(MooseX::App::Role)
      1 perl(MooseX::App::Utils)
      1 perl(MooseX::Types::Path::Class)
      1 perl(Path::Class)
      1 perl(Pod::Elemental)
      1 perl(Pod::Elemental::Selectors)
      1 perl(Pod::Elemental::Transformer::Nester)
      1 perl(Pod::Elemental::Transformer::Pod5)
      1 perl(Pod::Perldoc)
      1 perl(Scalar::Util)
      1 perl(Term::ANSIColor)
      1 perl(Term::ReadKey)
      1 perl(Text::WagnerFischer)
      1 perl(namespace::autoclean)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are ok.

$ rpm -qp --provides perl-MooseX-App-1.30-2.fc22.noarch.rpm | sort | uniq -c
      1 perl(Moose::Meta::Attribute::Custom::Trait::AppOption)
      1 perl(Moose::Meta::Attribute::Custom::Trait::AppTerm)
      1 perl(MooseX::App) = 1.30
      1 perl(MooseX::App::Command)
      1 perl(MooseX::App::Exporter)
      1 perl(MooseX::App::Message::Block)
      1 perl(MooseX::App::Message::BlockColor)
      1 perl(MooseX::App::Message::Envelope)
      1 perl(MooseX::App::Meta::Role::Attribute::Option)
      1 perl(MooseX::App::Meta::Role::Class::Base)
      1 perl(MooseX::App::Meta::Role::Class::Command)
      1 perl(MooseX::App::Meta::Role::Class::Documentation)
      1 perl(MooseX::App::Meta::Role::Class::Simple)
      1 perl(MooseX::App::Null)
      1 perl(MooseX::App::ParsedArgv)
      1 perl(MooseX::App::ParsedArgv::Element)
      1 perl(MooseX::App::Plugin::BashCompletion)
      1 perl(MooseX::App::Plugin::BashCompletion::Command)
      1 perl(MooseX::App::Plugin::BashCompletion::Meta::Class)
      1 perl(MooseX::App::Plugin::Color)
      1 perl(MooseX::App::Plugin::Color::Meta::Class)
      1 perl(MooseX::App::Plugin::Config)
      1 perl(MooseX::App::Plugin::Config::Meta::Class)
      1 perl(MooseX::App::Plugin::ConfigHome)
      1 perl(MooseX::App::Plugin::ConfigHome::Meta::Class)
      1 perl(MooseX::App::Plugin::Env)
      1 perl(MooseX::App::Plugin::Fuzzy)
      1 perl(MooseX::App::Plugin::Man)
      1 perl(MooseX::App::Plugin::Man::Command)
      1 perl(MooseX::App::Plugin::Man::Meta::Class)
      1 perl(MooseX::App::Plugin::Term)
      1 perl(MooseX::App::Plugin::Term::Meta::Attribute)
      1 perl(MooseX::App::Plugin::Term::Meta::Class)
      1 perl(MooseX::App::Plugin::Typo)
      1 perl(MooseX::App::Plugin::Typo::Meta::Class)
      1 perl(MooseX::App::Plugin::Version)
      1 perl(MooseX::App::Plugin::Version::Command)
      1 perl(MooseX::App::Plugin::Version::Meta::Class)
      1 perl(MooseX::App::Role)
      1 perl(MooseX::App::Role::Base)
      1 perl(MooseX::App::Role::Common)
      1 perl(MooseX::App::Simple) = 1.27
      1 perl(MooseX::App::Utils)
      1 perl-MooseX-App = 1.30-2.fc22
Binary provides are ok.

$ rpmlint ./perl-MooseX-App.spec ./perl-MooseX-App-1.30-2.*
perl-MooseX-App.src: W: spelling-error %description -l en_US customisable -> customization
perl-MooseX-App.src: W: spelling-error %description -l en_US qw -> q, w, aw
perl-MooseX-App.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
perl-MooseX-App.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MooseX-App.noarch: W: spelling-error %description -l en_US customisable -> customization
perl-MooseX-App.noarch: W: spelling-error %description -l en_US qw -> q, w, aw
perl-MooseX-App.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
perl-MooseX-App.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MooseX-App.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-MooseX-App/LICENCE
2 packages and 1 specfiles checked; 1 errors, 8 warnings.

Incorrect FSF address should be reported to upstream, otherwise rpmlint is ok.

Package APPROVED

Comment 4 Petr Šabata 2014-12-02 13:17:56 UTC
New Package SCM Request
=======================
Package Name: perl-MooseX-App
Short Description: Write user-friendly command line apps with even less suffering
Upstream URL: http://search.cpan.org/dist/MooseX-App/
Owners: psabata eseyman jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-12-02 13:52:49 UTC
Git done (by process-git-requests).

Comment 6 Petr Šabata 2014-12-02 14:44:15 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.