Description of problem: Today I was faced with the need to make following workaround to gsound (gnome git) in order to avoid a builddir != srcdir building problem exposed in gnome-continuous http://build.gnome.org/continuous/buildmaster/builds/2014/11/27/49/build/log-gsound.txt The change to fix it was "easy" but in my mind completely unnecessary gsound_play_VALAFLAGS = \ - --vapidir ${top_builddir}/gsound \ + --vapidir ${abs_top_builddir}/gsound \ --pkg gsound \ ${NULL} Important to have in mind the vapis themselves are a build product. What happens is that this cd in automake (lang_vala_finish_target:5000ish): "\t${verbose}\$(am__cd) \$(srcdir) && $compile @vala_sources\n". completely destroys the relative flags for valac. I had in mind this maybe fix? diff --git a/bin/automake.in b/bin/automake.in index 4cee0d0..5e33cf2 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -5476,6 +5476,7 @@ sub lang_vala_finish_target my $silent = silent_flag (); my $stampfile = "\$(srcdir)/${derived}_vala.stamp"; + map { $_ = "\$(srcdir)\/" . $_ } @vala_sources; $output_rules .= "\$(srcdir)/${derived}_vala.stamp: @vala_sources\n". # Since the C files generated from the vala sources depend on the @@ -5485,7 +5486,7 @@ sub lang_vala_finish_target # Thus we need to create the stamp file *before* invoking valac, and to # move it to its final location only after valac has been invoked. "\t${silent}rm -f \$\@ && echo stamp > \$\@-t\n". - "\t${verbose}\$(am__cd) \$(srcdir) && $compile @vala_sources\n". + "\t${verbose}\$compile -d \$(srcdir) @vala_sources\n". "\t${silent}mv -f \$\@-t \$\@\n"; push_dist_common ($stampfile);
+ "\t${verbose}\$compile -d \$(srcdir) @vala_sources\n". should be + "\t${verbose}$compile -d \$(srcdir) @vala_sources\n". of course sorry for the spam
Yanko, thanks for the report. Without trying that patch, the fix seems to be correct to me. The -d option has been handled by valac since its first commit to VCS; and switching cwd to $(srcdir) does not seem to necessary. This should be proposed upstream, could you please submit that patch to automake-patches? Pavel
http://lists.gnu.org/archive/html/automake-patches/2014-12/msg00000.html BTW the only minimal way I've tested this is to try if it fixed my gsound problem, not familiar with the testing plans for automake itself.
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
This message is a reminder that Fedora 24 is nearing its end of life. Approximately 2 (two) weeks from now Fedora will stop maintaining and issuing updates for Fedora 24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '24'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 24 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.