Bug 1169005 - RPM building of glusterfs-3.6.1-3.fc22 src RPM on el5 is failing
Summary: RPM building of glusterfs-3.6.1-3.fc22 src RPM on el5 is failing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1169004
TreeView+ depends on / blocked
 
Reported: 2014-11-28 19:57 UTC by Lalatendu Mohanty
Modified: 2015-05-14 17:45 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1169004
Environment:
Last Closed: 2015-05-14 17:28:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Lalatendu Mohanty 2014-11-28 19:57:26 UTC
+++ This bug was initially created as a clone of Bug #1169004 +++

Description of problem:
Rebuilding glusterfs-3.6.1-3.fc22.src.rpm for el5 is failing with below error.

Installed (but unpackaged) file(s) found:
   /usr/share/glusterfs/scripts/generate-gfid-file.sh
   /usr/share/glusterfs/scripts/get-gfid.sh
   /usr/share/glusterfs/scripts/gsync-sync-gfid
   /usr/share/glusterfs/scripts/gsync-upgrade.sh
   /usr/share/glusterfs/scripts/slave-upgrade.sh
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target ppc --nodeps  builddir/build/SPECS/glusterfs.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mockbuild/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.6/site-packages/mockbuild/util.py", line 378, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target ppc --nodeps  builddir/build/SPECS/glusterfs.spec']
LEAVE do --> EXCEPTION RAISED


glusterfs-3.6.1-3.fc22.src.rpm  can be found below

http://koji.fedoraproject.org/koji/buildinfo?buildID=594572

Version-Release number of selected component (if applicable):
3.6.1-3.fc22.

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Niels de Vos 2014-12-01 08:02:33 UTC
Ah, not merged in master, only in the Fedora package.

Comment 3 Niels de Vos 2014-12-01 08:17:07 UTC
The build fix in the .spec is fine so that the community packages can get out, but ideally we should not install those scripts when geo-repliation is not enabled.

I'll send a patch for that in a bit.

Comment 4 Anand Avati 2014-12-01 08:23:51 UTC
REVIEW: http://review.gluster.org/9221 (build: only install geo-rep scripts when enabled) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 5 Anand Avati 2014-12-07 14:16:13 UTC
COMMIT: http://review.gluster.org/9221 committed in master by Niels de Vos (ndevos) 
------
commit fcdac758ad7b3dda9843f92597a15e4a30a3b746
Author: Niels de Vos <ndevos>
Date:   Mon Dec 1 09:21:32 2014 +0100

    build: only install geo-rep scripts when enabled
    
    When geo-replication is not enabled, the related scripts should not get
    installed. EPEL-5 does not support geo-replication, and the installed
    but unpackaged scripts cause rebuilding for .el5 to fail.
    
    BUG: 1169005
    Change-Id: I1b6a352b73bd1ed1c5b330f54e26e81aed9a5a4e
    Reported-by: Lalatendu Mohanty <lmohanty>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9221
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Anand Avati 2014-12-12 13:16:38 UTC
REVIEW: http://review.gluster.org/9272 (build: prevent double packaging of geo-replication and other scripts) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 7 Anand Avati 2014-12-15 12:52:07 UTC
COMMIT: http://review.gluster.org/9272 committed in master by Niels de Vos (ndevos) 
------
commit 358576530c5503f251bc7f4c53cb04064a78aee6
Author: Niels de Vos <ndevos>
Date:   Fri Dec 12 14:12:35 2014 +0100

    build: prevent double packaging of geo-replication and other scripts
    
    The regression-tests sub-package contains /usr/share/glusterfs/* instead
    of including only the needed files. This causes some of the scripts that
    are part of geo-replication to be packaged twice.
    
    BUG: 1169005
    Change-Id: Ib452e73f3c1775b252ab257aab852ad9af857e74
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9272
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Tested-by: Gluster Build System <jenkins.com>

Comment 8 Niels de Vos 2015-05-14 17:28:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:35:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:38:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:45:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.