Bug 1169123 - Review Request: nodejs-entities - Encode & decode XML/HTML entities with ease
Summary: Review Request: nodejs-entities - Encode & decode XML/HTML entities with ease
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1169137
TreeView+ depends on / blocked
 
Reported: 2014-11-30 13:56 UTC by Piotr Popieluch
Modified: 2014-12-28 20:43 UTC (History)
2 users (show)

Fixed In Version: nodejs-entities-1.1.1-2.el7
Clone Of:
Environment:
Last Closed: 2014-12-14 12:39:07 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-11-30 13:56:11 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-entities.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-entities-1.1.1-1.fc21.src.rpm
Description: Encode & decode XML/HTML entities with ease
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 13:01:47 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-entities.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced
upstream tarball:  1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced

- License is "BSD" and not "MIT. 

+ License text is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Fix license tag

Comment 2 Piotr Popieluch 2014-12-06 14:33:05 UTC
thank you, fixed suggestions in:

Spec URL: https://piotrp.fedorapeople.org/nodejs-entities.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-entities-1.1.1-2.fc21.src.rpm

Comment 3 Parag AN(पराग) 2014-12-06 15:18:56 UTC
Looks good.

APPROVED.

Comment 4 Piotr Popieluch 2014-12-06 16:40:13 UTC
New Package SCM Request
=======================
Package Name: nodejs-entities
Short Description: Encode & decode XML/HTML entities with ease
Upstream URL: https://github.com/fb55/node-entities
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC: piotrp

Comment 5 Gwyn Ciesla 2014-12-08 14:08:28 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-12-08 21:23:25 UTC
nodejs-entities-1.1.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-entities-1.1.1-2.fc21

Comment 7 Fedora Update System 2014-12-08 21:24:07 UTC
nodejs-entities-1.1.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-entities-1.1.1-2.fc20

Comment 8 Fedora Update System 2014-12-08 21:24:33 UTC
nodejs-entities-1.1.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-entities-1.1.1-2.fc19

Comment 9 Fedora Update System 2014-12-08 21:25:03 UTC
nodejs-entities-1.1.1-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-entities-1.1.1-2.el7

Comment 10 Fedora Update System 2014-12-11 06:29:03 UTC
nodejs-entities-1.1.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 11 Piotr Popieluch 2014-12-14 12:39:07 UTC
Package built and in testing, closing bug.

Comment 12 Fedora Update System 2014-12-20 08:32:14 UTC
nodejs-entities-1.1.1-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-12-20 08:32:43 UTC
nodejs-entities-1.1.1-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2014-12-20 08:36:05 UTC
nodejs-entities-1.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2014-12-28 20:43:22 UTC
nodejs-entities-1.1.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.