Bug 116916 - tg3 driver doesn't support bonding driver's ALB mode
Summary: tg3 driver doesn't support bonding driver's ALB mode
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: kernel
Version: 3.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Miller
QA Contact: Brian Brock
URL:
Whiteboard: tg3
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-02-26 13:30 UTC by Martin Wilck
Modified: 2010-10-22 02:32 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-05-12 01:08:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
fix for MAC setting bug (702 bytes, patch)
2004-03-08 19:09 UTC, David Miller
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2004:188 0 normal SHIPPED_LIVE Important: Updated kernel packages available for Red Hat Enterprise Linux 3 Update 2 2004-05-11 04:00:00 UTC

Description Martin Wilck 2004-02-26 13:30:22 UTC
Description of problem:

It is impossible to use the adaptive load balancing (ALB) mode of the
Linux bonding driver with the tg3 base driver because the tg3 driver
doesn't support changing the MAC address of a running interface.

Version-Release number of selected component (if applicable):
2.4.21-9.EL and earlier

How reproducible:
always

Steps to Reproduce:
1.install system with Broadcom NIC and tg3
2.configure bonding driver with mode=6 using the Broadcom NIC
  
Actual results: the following error message:

bonding: Error: alb_set_mac_addr: dev->set_mac_address of dev eth0
failed! ALB mode requires that the base driver support setting the hw
address also when the network device's interface is open

Expected results:

ALB mode works.

Additional info:

Works with Broadcomn's bcm5700 driver, thus it is no Hardware problem

The following lines in tg3_set_mac_addr()  (tg3.c line 4523f.) seem to
be responsible:

        if (netif_running(dev))
                return -EBUSY;

Comment 2 David Miller 2004-03-08 19:08:54 UTC
Yes, that test is not needed at all, the fix is to simply remove
those two lines.


Comment 3 David Miller 2004-03-08 19:09:27 UTC
Created attachment 98376 [details]
fix for MAC setting bug

Comment 4 Martin Wilck 2004-03-09 08:26:34 UTC
Great, thanks.


Comment 7 Martin Wilck 2004-04-06 12:54:23 UTC
When will this part become part of an official RHEL kernel?


Comment 8 Ernie Petrides 2004-04-08 02:39:38 UTC
The tg3 driver has just been upgraded to v3.1 in tonight's
respin of RHEL3 U2 (kernel version 2.4.21-13.EL) to address
this problem.

Comment 9 John Flanagan 2004-05-12 01:08:36 UTC
An errata has been issued which should help the problem described in this bug report. 
This report is therefore being closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files, please follow the link below. You may reopen 
this bug report if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2004-188.html



Note You need to log in before you can comment on or make changes to this bug.