Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct-1.21-1.fc20.src.rpm Description: CGI::Struct lets you transform CGI data keys that look like perl data structures into actual perl data structures. Fedora Account System Username: eseyman
Oh c'mon, so many common things... Missing BRs: perl, Exporter, strict, warnings. The minimum required version of Test::Pod is 1.22. The minimum required version of Test::Pod::Coverage is 1.08. Consider limiting the BRs to these versions. 00-pod-coverage.t also optionally requires Pod::Coverage >= 0.18. Since you run the other optional tests, perhaps you'd like to run this one as well? Removal of empty directories is unnecessary (line 38). Since you're using the %license macro, I expect this to be purely a F21+ package. Consider utilizing NO_PACKLIST, too.
(In reply to Petr Šabata from comment #1) > Oh c'mon, so many common things... Yeah, sorry about that. :-( > Missing BRs: perl, Exporter, strict, warnings. added. > The minimum required version of Test::Pod is 1.22. > The minimum required version of Test::Pod::Coverage is 1.08. > Consider limiting the BRs to these versions. Done. > 00-pod-coverage.t also optionally requires Pod::Coverage >= 0.18. Since you > run the other optional tests, perhaps you'd like to run this one as well? Indeed. Added > Removal of empty directories is unnecessary (line 38). Removed. > Since you're using the %license macro, I expect this to be purely a F21+ > package. Consider utilizing NO_PACKLIST, too. Ah, I didn't know about this trick. Very cool. Done (and yes, this package is for F21 and devel). Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Struct/perl-CGI-Struct-1.21-2.fc20.src.rpm
Ok, I'm going to approve this now. Just a note: NO_PACKLIST requires EU::MM >= 6.76. I suggest you add that version constraint before pushing the package.
(In reply to Petr Šabata from comment #3) > Ok, I'm going to approve this now. Thank you. > Just a note: NO_PACKLIST requires EU::MM >= 6.76. I suggest you add that > version constraint before pushing the package. Added (without bumping the release number). New Package SCM Request ======================= Package Name: perl-CGI-Struct Short Description: Build structures from CGI data Upstream URL: http://search.cpan.org/dist/CGI-Struct/ Owners: eseyman Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
Built for rawhide and released as an update for Fedora 21.