Bug 1169358 - Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST
Summary: Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1168861
TreeView+ depends on / blocked
 
Reported: 2014-12-01 12:38 UTC by Emmanuel Seyman
Modified: 2014-12-05 12:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-12-05 12:56:50 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2014-12-01 12:38:46 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride-0.10-1.fc20.src.rpm
Description:
This Plack middleware allows your apps to override any HTTP method over POST.
Specifically, you can provide a query parameter named "x-tunneled-method"
or a header named "x-http-method-override" (as used by Google's APIs).
Either way, the overriding works only via POST requests, not GET.

Fedora Account System Username: eseyman

rpmlint output:
perl-Plack-Middleware-MethodOverride.src: W: spelling-error %description -l en_US http -> HTTP
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

This package is needed to update perl-Catalyst-Runtime to the latest upstream version.

Comment 1 Jitka Plesnikova 2014-12-04 16:04:24 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Plack-Middleware-MethodOverride-0.10-1.fc22.noarch.rpm | sort | uniq -c
      1 perl >= 1:5.8.1
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Plack::Middleware)
      1 perl(URI)
      1 perl(parent)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Plack-Middleware-MethodOverride-0.10-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(Plack::Middleware::MethodOverride) = 0.10
      1 perl-Plack-Middleware-MethodOverride = 0.10-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-Plack-Middleware-MethodOverride.spec ./perl-Plack-Middleware-MethodOverride-0.10-1.fc22.*
perl-Plack-Middleware-MethodOverride.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-Plack-Middleware-MethodOverride.src: W: spelling-error %description -l en_US http -> HTTP
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

TODO: Remove BRs perl(Test::Builder), perl(Test::Pod::Coverage), they are
not used

Otherwise package is good.

Package APPROVED.

Comment 2 Emmanuel Seyman 2014-12-04 20:30:12 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> TODO: Remove BRs perl(Test::Builder), perl(Test::Pod::Coverage), they are
> not used

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride-0.10-2.fc20.src.rpm

> Package APPROVED.

Thank you, Jikta.
Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Plack-Middleware-MethodOverride
Short Description: Override REST methods to Plack apps via POST
Upstream URL: http://search.cpan.org/dist/Plack-Middleware-MethodOverride/
Owners: eseyman
Branches: f21
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2014-12-04 22:01:30 UTC
Git done (by process-git-requests).

Comment 4 Emmanuel Seyman 2014-12-05 12:56:50 UTC
Built for rawhide and released as an update for Fedora 21.


Note You need to log in before you can comment on or make changes to this bug.