Spec URL: https://than.fedorapeople.org/f21/kbrickbuster.spec SRPM URL: https://than.fedorapeople.org/f21/kbrickbuster-4.14.3-1.fc20.src.rpm Description: The objective KBrickbuster game is to destroy as many bricks as possible without losing the ball. Fedora Account System Username: than
Looks good, but I'll echo what I mentioned in bug #1167062 1. the Obsoletes/Provides MUST to be versioned, options include: 1a. start kbrickbuster at some higher Release, like: Release: 10 combined with: Obsoletes: kbreakout < 4.14.3-10 Provides: kbreakout = %{version}-%{release} 1b. alternatively, to ensure it kbrickbuster always wins, could even introduce an Epoch in the Obsoletes/Provides, Obsoletes: kbreakout < 1:4.14.3-1 Provides: kbreakout = 1:%{version}-%{release} 2. Sources: Not ok, cannot verify. .spec currently includes: #Source0: http://download.kde.org/%{stable}/%{version}/src/%{name}-%{version}.tar.xz # patched source, rename the game Source0: kbrickbuster-4.14.3-rename.tar.xz SHOULD include a script to automate this renaming process. (doing this manually for every release would be tedious)
i'm fixing 1 and 2, will upload new srpm for review. Thanks
Hello. How it this bug current status ? Thanks.
I guess we're still waiting for the promised fixes per comment #2
sadly i have been sick this week. It's my high prio task for next week.
i uploaded new spec and srpm, it fixes 1 and 2. Spec URL: https://than.fedorapeople.org/f21/kbrickbuster.spec SRPM URL: https://than.fedorapeople.org/f21/kbrickbuster-4.14.3-1.fc21.src.rpm Rex, could you please review it? Thanks
FYI, rawhide (and f21/f20) are now up to, kbreakout-14.12.1-1 but I would assume that adapting this for it would be easy (just rebase to higher Version and respin the package). Otherwise, package looks good, thanks: APPROVED
the script works fine for new version 14.12.1-1.
New Package SCM Request ======================= Package Name: kbrickbuster Short Description: Destroy bricks with a ball Upstream URL: https://projects.kde.org/projects/kde/kdegames/kbrickbuster Owners: than rdieter jgrulich dvratil kkofler ltinkl group::kde-sig Branches: f20 f21 f22 InitialCC: group::kde-sig
Git done (by process-git-requests).
it's imported to fedora git