Spec URL: https://jorti.fedorapeople.org/python-django-database-url/python-django-database-url.spec SRPM URL: https://jorti.fedorapeople.org/python-django-database-url/python-django-database-url-0.3.0-2.fc21.src.rpm Description: This simple Django utility allows you to utilize the 12factor inspired DATABASE_URL environment variable to configure your Django application. Fedora Account System Username: jorti
Spec URL: https://jorti.fedorapeople.org/python-django-database-url/python-django-database-url.spec SRPM URL: https://jorti.fedorapeople.org/python-django-database-url/python-django-database-url-0.3.0-3.fc21.src.rpm
The only remarks I have are: - The test is only run for the default python interpreter (i.e. currently python2). Could be a good idea to explicitly pass the python interpreter to use to the Makefile and run it for both python2 and python3. - Group can be omitted if desired: http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag - For future-proofing, use %license for the license, see https://fedorahosted.org/fpc/ticket/411 Otherwise, looks good, approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. Python: [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. => Note: Only tested with python2 [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-django-database-url-0.3.0-3.fc22.noarch.rpm python3-django-database-url-0.3.0-3.fc22.noarch.rpm python-django-database-url-0.3.0-3.fc22.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rpmlint python3-django-database-url python-django-database-url 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python3-django-database-url (rpmlib, GLIBC filtered): python(abi) python3-django python-django-database-url (rpmlib, GLIBC filtered): python(abi) python-django Provides -------- python3-django-database-url: python3-django-database-url python-django-database-url: python-django-database-url Source checksums ---------------- https://github.com/kennethreitz/dj-database-url/archive/c9c933f1bd3087cdbbf9d6abfd26b91f4fa8f8cb/dj-database-url-c9c933f1bd3087cdbbf9d6abfd26b91f4fa8f8cb.tar.gz : CHECKSUM(SHA256) this package : c7fb092bc3f95f969aef391a79408cf7af1eb9612559303304e80058cd6fe50e CHECKSUM(SHA256) upstream package : c7fb092bc3f95f969aef391a79408cf7af1eb9612559303304e80058cd6fe50e Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1170069 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Hi Juan, are you still pursuing this?
I totally forgot about it, thanks for the reminder.
New Package SCM Request ======================= Package Name: python-django-database-url Short Description: Use Database URLs in your Django Application Upstream URL: https://github.com/kennethreitz/dj-database-url Owners: jorti Branches: f20 f21 f22 InitialCC:
Git done (by process-git-requests).
python-django-database-url-0.3.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-django-database-url-0.3.0-3.fc22
python-django-database-url-0.3.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-django-database-url-0.3.0-3.fc21
python-django-database-url-0.3.0-3.fc21 has been pushed to the Fedora 21 testing repository.
python-django-database-url-0.3.0-3.fc21 has been pushed to the Fedora 21 stable repository.
python-django-database-url-0.3.0-3.fc22 has been pushed to the Fedora 22 stable repository.