Spec URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266.spec SRPM URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266-0.0.4-2.fc21.src.rpm Description: This module parses and generates HTTP Content-Disposition headers. These headers are used when getting resources for download; they provide a hint of whether the file should be downloaded, and of what filename to use when saving. Fedora Account System Username: jorti
Hi Juan! There are a few things: [ ] Spec file according to URL is the same as in SRPM. [ ] Please rename the directory "%{py3dir}" [ ] A License file is missing [ ] And https://github.com/g2p/rfc6266/blob/master/COPYING refers to GPLv3 while the spec-file says LGPLv2 Cheers, flo
Hello, thanks for reviewing. (In reply to Florian "der-flo" Lehner from comment #1) > Hi Juan! > > There are a few things: > > [ ] Spec file according to URL is the same as in SRPM. I've updated the URLs > [ ] Please rename the directory "%{py3dir}" I don't understand this one > [ ] A License file is missing It's not shipped in the tarball, I have switched to GitHub, which includes the full license text > while the spec-file says LGPLv2 Since the LGPL is a set of additional permissions on top of the GPL, they include both license texts, but the source code is LGPLv3, I've updated the spec to reflect this. Updated files: Spec URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266.spec SRPM URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266-0.0.4-3.fc21.src.rpm
hi Juan! > > [ ] Please rename the directory "%{py3dir}" > > I don't understand this one Sorry - this was my misstake! There is just one more thing: Please rename the downloaded source-file. You can do this following the guide on https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github or [...] Source0: https://github.com/g2p/rfc6266/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz [...] and [...] %pre %setup -q [...] Doing so it is much easier to assign a file called v0.123.tar.gz to its origin. Cheers, flo
(In reply to Florian "der-flo" Lehner from comment #3) > There is just one more thing: > Please rename the downloaded source-file. You can do this following the > guide on > https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/ > SourceURL#Github I've used the commit hash to avoid confusions. Spec URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266.spec SRPM URL: https://jorti.fedorapeople.org/python-rfc6266/python-rfc6266-0.0.4-4.fc21.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 6 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4/site-packages/__pycache__, /usr/lib/python3.4 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4/site-packages/__pycache__, /usr/lib/python3.4 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-rfc6266 [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8296036 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-rfc6266-0.0.4-4.fc22.noarch.rpm python3-rfc6266-0.0.4-4.fc22.noarch.rpm python-rfc6266-0.0.4-4.fc22.src.rpm python-rfc6266.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament python3-rfc6266.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament python-rfc6266.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-rfc6266 python3-rfc6266 python-rfc6266.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament python3-rfc6266.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- python-rfc6266 (rpmlib, GLIBC filtered): python(abi) python3-rfc6266 (rpmlib, GLIBC filtered): python(abi) Provides -------- python-rfc6266: python-rfc6266 python3-rfc6266: python3-rfc6266 Source checksums ---------------- https://github.com/g2p/rfc6266/archive/2710353e5fe09ca73d555e2fbca80c4ee12a99d6/rfc6266-2710353e5fe09ca73d555e2fbca80c4ee12a99d6.tar.gz : CHECKSUM(SHA256) this package : 02cb76942c01c0792769c0a958e04ffad03e9c2882f0844bcc55bf4c80497caf CHECKSUM(SHA256) upstream package : 02cb76942c01c0792769c0a958e04ffad03e9c2882f0844bcc55bf4c80497caf Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1170072 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Solution ===== APPROVED
New Package SCM Request ======================= Package Name: python-rfc6266 Short Description: Parse and generate Content-Disposition headers Upstream URL: https://github.com/g2p/rfc6266 Owners: jorti Branches: f19 f20 f21 InitialCC:
Git done (by process-git-requests).
python-rfc6266-0.0.4-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-rfc6266-0.0.4-4.fc20
python-rfc6266-0.0.4-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-rfc6266-0.0.4-4.fc19
python-rfc6266-0.0.4-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-rfc6266-0.0.4-4.fc21
python-rfc6266-0.0.4-4.fc21 has been pushed to the Fedora 21 stable repository.
python-rfc6266-0.0.4-4.fc20 has been pushed to the Fedora 20 stable repository.
python-rfc6266-0.0.4-4.fc19 has been pushed to the Fedora 19 stable repository.