RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1170205 - pcs cluster auth --force doesn't overwrite /var/lib/pcsd/tokens if its content is corrupt
Summary: pcs cluster auth --force doesn't overwrite /var/lib/pcsd/tokens if its conten...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: ---
Assignee: Ondrej Mular
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-03 13:48 UTC by Radek Steiger
Modified: 2015-11-19 09:33 UTC (History)
4 users (show)

Fixed In Version: pcs-0.9.140-1.el7
Doc Type: Bug Fix
Doc Text:
Cause: Users runs command 'pcs cluster auth --force' when token file (/var/lib/pcsd/tokens) is corrupted Consequence: Authentication succeeded, but nodes are not authorized. Fix: Pcs always locks and rewrites whole file when updating tokens. Result: Nodes are authorized.
Clone Of:
Environment:
Last Closed: 2015-11-19 09:33:52 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1158577 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Product Errata RHSA-2015:2290 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2015-11-19 09:43:53 UTC

Internal Links: 1158577

Description Radek Steiger 2014-12-03 13:48:51 UTC 
> Description of problem:

If the content of /var/lib/pcsd/tokens gets corrupted and is not a parseable JSON file, reauthenticating with the --force flag will only update the file's timestamp, but leaves its invalid content intact and doesn't produce any error. The --force flag should be able to overwrite the file even if the content is not parseable.

Example of the /var/lib/pcsd/tokens corruption:

{"tardis-03": "d77c8415-e76d-4f6c-8963-b4e04e77898f"} "tardis-02": "bef1fc5c-d140-4d2d-b3ab-6df902d9139f"} "tardis-02": "bef1fc5c-d140-4d2d-b3ab-6df902d9139f"}


> Version-Release number of selected component (if applicable):

pcs-0.9.137-1.el7


> How reproducible:

Easily


> Steps to Reproduce:

1. Create a currupted tokens file (see example above)
2. Run pcs cluster auth --force
3. Check authentication with pcs status


> Actual results:

Re-authentication passes but pcs status shows as not authenticated. Tokens file content has been left intact.


> Expected results:

Authentication re-creates the tokens file and pcsd is auth'd correctly.
Comment 2 Tomas Jelinek 2015-01-29 14:01:48 UTC 
Upstream here:
https://github.com/feist/pcs/commit/d1371df02773f0ae90b8a7de94099ef842d64867
Comment 5 Ondrej Mular 2015-05-04 08:55:55 UTC 
Test:

1. Create a corrupted tokens file
2. Run pcs cluster auth --force
3. Check authentication with pcs status
4. Token file is overwritten and nodes are authorized
Comment 6 Tomas Jelinek 2015-06-04 14:34:15 UTC 
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Online
  rh71-node2: Online
  rh71-node3: Online
[root@rh71-node1:~]# wc -c /var/lib/pcsd/tokens
162 /var/lib/pcsd/tokens
[root@rh71-node1:~]# truncate -s 100 /var/lib/pcsd/tokens
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Unable to authenticate
  rh71-node2: Unable to authenticate
  rh71-node3: Unable to authenticate
[root@rh71-node1:~]# pcs cluster auth rh71-node1 rh71-node2 rh71-node3 --force
Username: hacluster
Password: 
rh71-node1: Authorized
rh71-node2: Authorized
rh71-node3: Authorized
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Unable to authenticate
  rh71-node2: Unable to authenticate
  rh71-node3: Unable to authenticate



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Online
  rh71-node2: Online
  rh71-node3: Online
[root@rh71-node1:~]# wc -c /var/lib/pcsd/tokens
238 /var/lib/pcsd/tokens
[root@rh71-node1:~]# truncate -s 100 /var/lib/pcsd/tokens
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Unable to authenticate
  rh71-node2: Unable to authenticate
  rh71-node3: Unable to authenticate
[root@rh71-node1:~]# pcs cluster auth rh71-node1 rh71-node2 rh71-node3 --force
Username: hacluster
Password: 
rh71-node3: Authorized
rh71-node2: Authorized
rh71-node1: Authorized
[root@rh71-node1:~]# pcs status pcsd
  rh71-node1: Online
  rh71-node2: Online
  rh71-node3: Online
Comment 10 errata-xmlrpc 2015-11-19 09:33:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html
Note You need to log in before you can comment on or make changes to this bug.