Bug 1170354 - Typos in nfs-utils sysconfig files and associated script
Summary: Typos in nfs-utils sysconfig files and associated script
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nfs-utils
Version: 21
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Steve Dickson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1173529 1174642 (view as bug list)
Depends On:
Blocks: 1170364
TreeView+ depends on / blocked
 
Reported: 2014-12-03 21:09 UTC by Bojan Smojver
Modified: 2015-05-13 17:35 UTC (History)
6 users (show)

Fixed In Version: nfs-utils-1.3.1-4.1.fc21
Clone Of:
: 1170364 (view as bug list)
Environment:
Last Closed: 2015-01-14 07:28:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bojan Smojver 2014-12-03 21:09:08 UTC
Description of problem:
Various typos in /etc/sysconfig/nfs file and /usr/lib/systemd/scripts/nfs-utils_env.sh script.

Version-Release number of selected component (if applicable):
nfs-utils-1.3.1-2.2.fc21.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Try to start NFS on fixed ports by adjusting /etc/sysconfig/nfs

Actual results:
Does not work.

Expected results:
Worked in F-20.

Additional info:
Script /usr/lib/systemd/scripts/nfs-utils_env.sh has:
-----------
echo RPCNFSDARGS="$nfsdargs"
echo RPCMOUNTDOPTS="$RPCMOUNTDOPTS"
echo STATDARG="$STATDARG"
echo RPCIDMAPDARGS="$RPCIDMAPDARGS"
echo RPCGSSDARGS="$RPCGSSDARGS"
echo RPCSVCGSSDARGS="$RPCSVCGSSDARGS"
echo BLKMAPDARGS="$BLKMAPDARGS"
-----------

nfs-mountd.service uses RPCMOUNTDARGS, not RPCMOUNTDOPTS.

rpc-statd.service uses STATDARGS, not STATDARG.

So, both the script and default /etc/sysconfig/nfs need to be fixed to make this work and avoid misleading people into setting variables that do nothing.

Comment 1 Bojan Smojver 2014-12-10 04:03:01 UTC
Just saw commit 5fc4da530ee16c4185f5f9e2583d8d18c16008f7.

Isn't that still confusing? Calling the variable one thing in the sysconfig file and another in the service file?

I mean, if you want to have backwards compatibility, maybe you can accept the old ones, but overwrite them with new ones, if those are set?

Comment 2 Steve Dickson 2014-12-10 11:54:49 UTC
(In reply to Bojan Smojver from comment #1)
> Just saw commit 5fc4da530ee16c4185f5f9e2583d8d18c16008f7.
> 
> Isn't that still confusing? Calling the variable one thing in the sysconfig
> file and another in the service file?
> 
> I mean, if you want to have backwards compatibility, maybe you can accept
> the old ones, but overwrite them with new ones, if those are set?

Admins should only now about the variables in the sysconfig file and
yes I wanted those to be backwards compatible. The variables used
in the systemd scripts are just a means to an end...

Comment 3 Bojan Smojver 2014-12-12 00:24:29 UTC
(In reply to Steve Dickson from comment #2)
 
> Admins should only now about the variables in the sysconfig file and
> yes I wanted those to be backwards compatible. The variables used
> in the systemd scripts are just a means to an end...

Look, it's your package and you can do with it what you like. However, I can tell you this. I am an admin. When the thing didn't work, the first thing I did was to check the systemd service file to see what is actually used there. Counting on admins that are setting up NFS on fixed ports not to look is unrealistic.

So, I'd make it work with both sets of variables. IMHO etc.

Comment 4 Steve Dickson 2014-12-12 09:47:04 UTC
(In reply to Bojan Smojver from comment #3)
> (In reply to Steve Dickson from comment #2)
>  
> > Admins should only now about the variables in the sysconfig file and
> > yes I wanted those to be backwards compatible. The variables used
> > in the systemd scripts are just a means to an end...
> 
> Look, it's your package and you can do with it what you like. However, I can
> tell you this. I am an admin. When the thing didn't work, the first thing I
> did was to check the systemd service file to see what is actually used
> there. Counting on admins that are setting up NFS on fixed ports not to look
> is unrealistic.
> 
> So, I'd make it work with both sets of variables. IMHO etc.

Thanks for the input... I'll look to make this change in f22...

Comment 5 Steve Dickson 2014-12-13 19:47:22 UTC
*** Bug 1173529 has been marked as a duplicate of this bug. ***

Comment 6 Fedora Update System 2014-12-14 19:02:03 UTC
nfs-utils-1.3.1-4.0.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/FEDORA-2014-15315/nfs-utils-1.3.1-4.0.fc21

Comment 7 Steve Dickson 2014-12-16 15:07:02 UTC
*** Bug 1174642 has been marked as a duplicate of this bug. ***

Comment 8 Fedora Update System 2014-12-17 04:40:16 UTC
Package nfs-utils-1.3.1-4.0.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nfs-utils-1.3.1-4.0.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15315/nfs-utils-1.3.1-4.0.fc21
then log in and leave karma (feedback).

Comment 9 Bojan Smojver 2015-01-01 23:55:58 UTC
BTW, I just found this in logs:

Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]: /usr/lib/systemd/scripts/nfs-utils_env.sh: line 21: [: : integer expression expected
Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]: /usr/lib/systemd/scripts/nfs-utils_env.sh: line 25: [: : integer expression expected
Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]: /usr/lib/systemd/scripts/nfs-utils_env.sh: line 29: [: : integer expression expected

When the variables that appear on those lines of the script are not set, the above warnings are emitted to the journal.

Comment 10 Steve Dickson 2015-01-02 14:04:57 UTC
(In reply to Bojan Smojver from comment #9)
> BTW, I just found this in logs:
> 
> Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]:
> /usr/lib/systemd/scripts/nfs-utils_env.sh: line 21: [: : integer expression
> expected
> Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]:
> /usr/lib/systemd/scripts/nfs-utils_env.sh: line 25: [: : integer expression
> expected
> Jan 02 10:44:54 shrek.rexursive.com nfs-utils_env.sh[804]:
> /usr/lib/systemd/scripts/nfs-utils_env.sh: line 29: [: : integer expression
> expected
> 
> When the variables that appear on those lines of the script are not set, the
> above warnings are emitted to the journal.

This should be fixed in the latest updated nfs-utils-1.3.1-4.1.fc21

Comment 11 Fedora Update System 2015-01-03 19:11:43 UTC
Package nfs-utils-1.3.1-4.1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nfs-utils-1.3.1-4.1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15315/nfs-utils-1.3.1-4.1.fc21
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2015-01-14 07:28:21 UTC
nfs-utils-1.3.1-4.1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Andrei Amuraritei 2015-04-09 10:23:07 UTC
This is still present in nfs-utils-1.3.2-3.fc22, for example:

rpc-gssd.service has ExecStart=/usr/sbin/rpc.gssd $GSSDARGS
but /etc/sysconfig/nfs and nfs-utils_env.sh script have RPCGSSDARGS.

Same for rpc-svcgssd.

Meaning if I add -vvv to /etc/sysconfig/nfs RPCGSSDARGS I don't get them when rpc-gssd.service is started.

Comment 14 Jesse Connell 2015-05-13 16:35:25 UTC
(In reply to Fedora Update System from comment #12)
> nfs-utils-1.3.1-4.1.fc21 has been pushed to the Fedora 21 stable repository.
> If problems still persist, please make note of it in this bug report.

I'm still seeing the same incorrect behavior for GSSDARGS versus RPCGSSDARGS in nfs-utils-1.3.1-6.3.fc21.  (The rpc.gssd arguments specified in /etc/sysconfig/nfs are ignored unless I prepend "RPC" to the variable name in the rpc-gssd.service unit file.)


Note You need to log in before you can comment on or make changes to this bug.