Description of problem:

CFME fails to collect scvmm inventory with the following errors. 

[----] E, [2014-12-03T13:06:36.491503 #60005:ce1030] ERROR -- : MIQ(MiqQueue.deliver)    Message id: [1000000222915], Error: [undefined method `[]' for nil:NilClass]
[----] E, [2014-12-03T13:06:36.491723 #60005:ce1030] ERROR -- : [NoMethodError]: undefined method `[]' for nil:NilClass  Method:[rescue in deliver]
[----] E, [2014-12-03T13:06:36.492078 #60005:ce1030] ERROR -- : /var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:344:in `process_vm_guest_devices'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:276:in `process_vm_hardware'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:154:in `parse_vm'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:65:in `block in get_vms'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:547:in `block in process_collection'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:546:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:546:in `process_collection'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:65:in `get_vms'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:32:in `ems_inv_to_hashes'
/var/www/miq/vmdb/app/models/ems_refresh/parsers/scvmm.rb:8:in `ems_inv_to_hashes'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/scvmm_refresher.rb:23:in `block in refresh'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/scvmm_refresher.rb:12:in `each'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/scvmm_refresher.rb:12:in `refresh'
/var/www/miq/vmdb/app/models/ems_refresh/refreshers/base_refresher.rb:8:in `refresh'
/var/www/miq/vmdb/app/models/ems_refresh.rb:76:in `block in refresh'
/var/www/miq/vmdb/app/models/ems_refresh.rb:75:in `each'
/var/www/miq/vmdb/app/models/ems_refresh.rb:75:in `refresh'
/var/www/miq/vmdb/app/models/miq_queue.rb:361:in `block in deliver'
/opt/rh/ruby193/root/usr/share/ruby/timeout.rb:69:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:357:in `deliver'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:107:in `deliver_queue_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:135:in `deliver_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:152:in `block in do_work'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `loop'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `do_work'
/var/www/miq/vmdb/lib/workers/worker_base.rb:317:in `block in do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:314:in `loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:314:in `do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:135:in `run'
/var/www/miq/vmdb/lib/workers/worker_base.rb:123:in `start'
/var/www/miq/vmdb/lib/workers/worker_base.rb:23:in `start_worker'
/var/www/miq/vmdb/lib/workers/bin/worker.rb:5:in `<top (required)>'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands/runner.rb:52:in `eval'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands/runner.rb:52:in `<top (required)>'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:64:in `require'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:64:in `<top (required)>'
script/rails:6:in `require'
script/rails:6:in `<main>'


SCVMM errors. 

Virtual machine  cannot be modified because Virtual Guest Services is not installed on the guest operating system or because the installed Virtual Guest Services does not support the Heartbeat and Data Exchange Integration Services in the current virtual machine status. Error">ID: 30101 Verify the virtual machine is in a Running status, the Virtual Guest Services is installed, and the Heartbeat and Data Exchange Integration Services are enabled.



Version-Release number of selected component (if applicable): 5.3.1


How reproducible:
very

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
 test fix 

Delete this method 

def process_vm_guest_devices(vm)
dvdprops = vm[:Properties][:Props][:VirtualDVDDrives][0][:Props]
connection = dvdprops[:Connection]
devices = []
devices << case connection
when "HostDrive" then process_vm_physical_dvd_drive(dvdprops)
when "ISOImage" then process_iso_image(vm)
end
devices.compact
end

Paste in this new method

def process_vm_guest_devices(vm)
      dvds = vm[:Properties][:Props][:VirtualDVDDrives]
      return nil if dvds.empty?

      dvdprops   = dvds[0][:Props]
      connection = dvdprops[:Connection]
      devices    = []

      devices << case connection
                 when "HostDrive" then process_vm_physical_dvd_drive(dvdprops)
                 when "ISOImage"  then process_iso_image(vm)
                 end

      devices.compact
    end


Save the file. 


Restart the evmserverd service 

-service evmserverd restart