Bug 1170592
| Summary: | rpm.rpmva only working when --verify set, should be documented | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Martin Frodl <mfrodl> | ||||
| Component: | sos | Assignee: | Pavel Moravec <pmoravec> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Miroslav HradĂlek <mhradile> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.0 | CC: | agk, bhubbard, isenfeld, mfrodl, mhradile, sbradley | ||||
| Target Milestone: | rc | Keywords: | Documentation, Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | sos-3.3-0.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Prior to this update, the rpm.rpmva sos option was applied only in conjunction to --verify option. This was confusing for users wanting to collect "rpm -Va" command output. With this update, it is sufficient to provide rpm.rpmva option alone to let sos invoke that command.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 1382018 (view as bug list) | Environment: | |||||
| Last Closed: | 2016-11-04 04:52:59 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1298112, 1313485, 1382018 | ||||||
| Attachments: |
|
||||||
|
Description
Martin Frodl
2014-12-04 12:25:59 UTC
Could you attach the sos.log (or the whole tarball)? Created attachment 964632 [details]
sos.log
Sure, here you are.
Thanks - just wanted to check that nothing else was going on here. In sos-3.2 no verification happens unless the global '--verify' option is enabled. Since 'rpm.rpmva' turns on *additional* verification (i.e. "rpm -Va" rather than the targeted package verify list) it will not do anything unless you also specify verify. This is not a bug but we should probably improve the documentation of this behavior. E.g.: # sosreport -v --verify --batch --debug -o rpm -k rpm.rpmva sosreport (version 3.2) [...] Running 1/1: rpm... [plugin:rpm] collecting output of 'rpm -Va' It still seems to me the option -k is not working as expected. When testing bug 1084990, I tried to enable the option docker.all which should collect the output of 'docker ps -a' command, as opposed to 'docker ps' when this option is not set. In both cases, I only found 'docker ps' output in the archive. Also, sosreport with '-o apache' results in httpd's access_log and error_log files being included in the archive, no matter whether the '-k apache.log' option is present or not. The docker plugin is working fine for me. The behaviour of 'docker.all' as implemented is to collect *logs* for all containers (active and inactive). It does not collect the output of "docker ps -a" and store it in the report (although I think you can argue that it should).
This is how it behaves:
# sosreport -v --batch --debug --build -o docker -k docker.all
sosreport (version 3.2)
[...]
Setting up plugins ...
[plugin:docker] added copyspec '/var/lib/docker/repositories-*'
[plugin:docker] added cmd output 'docker info'
[plugin:docker] added cmd output 'docker ps'
[plugin:docker] added cmd output 'docker images'
[plugin:docker] added cmd output 'docker logs 9b8f61c09dba'
[plugin:docker] added cmd output 'docker logs 6f46267c91d6'
[plugin:docker] added cmd output 'docker logs '
[plugin:docker] added copyspec '/etc/udev/rules.d/80-docker.rules'
Running plugins. Please wait ...
# sosreport -v --batch --debug --build -o docker
sosreport (version 3.2)
[...]
Setting up plugins ...
[plugin:docker] added copyspec '/var/lib/docker/repositories-*'
[plugin:docker] added cmd output 'docker info'
[plugin:docker] added cmd output 'docker ps'
[plugin:docker] added cmd output 'docker images'
[plugin:docker] added cmd output 'docker logs '
[plugin:docker] added copyspec '/etc/udev/rules.d/80-docker.rules'
Running plugins. Please wait ...
Without 'docker.all' we do not generate the two additional 'docker logs <container ID>' commands.
This patch came from one of our Ubuntu developers and imho the plugin should *also* store the 'docker ps -a' - I'll file an issue and send a patch upstream for that but otherwise the plugin is currently working as designed.
> Also, sosreport with '-o apache' results in httpd's access_log and error_log
> files being included in the archive, no matter whether the '-k apache.log'
> option is present or not.
That's not what the option does. The plugin will always attempt to collect up to 5M each of access_log, error_log, ssl_access_log, ssl_error_log. If the apache.log option is given then *all* files under /var/log/httpd (including custom logs defined in httpd.conf or elsewhere) are collected without any size limitations.
This option should probably be merged with the global '--all-logs' but it is working as designed currently.
Point taken, thanks for your kind explanation. To sum things up: what needs to be changed is the documentation which should make clear that rpm.rpmva only works when the --verify option is set. I am changing the bug's summary in order to make this request more explicit. Please remember to include the information both in online help and man page; currently, the --verify option is only present in online help (this issue has been reported as bug 1171658). The requirement for --verify to be set for rpmva to work has been removed upstream with this commit. https://github.com/sosreport/sos/commit/56614f20abb22e7e6c891fc83a9f2c9149646586 This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2380.html |