Bug 1170815 - Review Request: nodejs-astral-pass - Pass helper for Astral that simplifies traversal.
Summary: Review Request: nodejs-astral-pass - Pass helper for Astral that simplifies ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1170816
TreeView+ depends on / blocked
 
Reported: 2014-12-04 22:41 UTC by Piotr Popieluch
Modified: 2014-12-26 19:50 UTC (History)
2 users (show)

Fixed In Version: nodejs-astral-pass-0.1.0-2.el7
Clone Of:
Environment:
Last Closed: 2014-12-14 12:34:30 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-04 22:41:13 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-astral-pass.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-astral-pass-0.1.0-1.fc21.src.rpm
Description: Pass helper for Astral that simplifies traversal.
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 15:17:01 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-astral-pass.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: c7b7380bc4b7843568b5829edfc075356aa2d597b9dacc7143afb6ac32348dd7
upstream tarball:  c7b7380bc4b7843568b5829edfc075356aa2d597b9dacc7143afb6ac32348dd7

+ License is "MIT" 

- License text is NOT included.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) License text is not present, please request upstream to add it.

Comment 3 Parag AN(पराग) 2014-12-07 17:54:43 UTC
Looks good now. Don't forget to keep asking upstream to include license text and when available update the package.

APPROVED.

Comment 4 Piotr Popieluch 2014-12-07 18:10:47 UTC
New Package SCM Request
=======================
Package Name: nodejs-astral-pass
Short Description: Pass system for Astral
Upstream URL: https://github.com/btford/astral-pass
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-12-08 14:13:33 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-12-09 09:50:48 UTC
nodejs-astral-pass-0.1.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-astral-pass-0.1.0-2.fc21

Comment 7 Fedora Update System 2014-12-09 09:51:18 UTC
nodejs-astral-pass-0.1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-astral-pass-0.1.0-2.fc20

Comment 8 Fedora Update System 2014-12-09 09:51:58 UTC
nodejs-astral-pass-0.1.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-astral-pass-0.1.0-2.fc19

Comment 9 Fedora Update System 2014-12-09 09:52:40 UTC
nodejs-astral-pass-0.1.0-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-astral-pass-0.1.0-2.el7

Comment 10 Fedora Update System 2014-12-11 06:33:00 UTC
nodejs-astral-pass-0.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 11 Piotr Popieluch 2014-12-14 12:34:30 UTC
Package built and in testing, closing bug.

Comment 12 Fedora Update System 2014-12-20 08:40:35 UTC
nodejs-astral-pass-0.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-12-20 08:41:08 UTC
nodejs-astral-pass-0.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-12-20 08:50:45 UTC
nodejs-astral-pass-0.1.0-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 15 Fedora Update System 2014-12-26 19:50:52 UTC
nodejs-astral-pass-0.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.