Bug 1170824 - Review Request: nodejs-async-each - Async parallel forEach / map function for JavaScript
Summary: Review Request: nodejs-async-each - Async parallel forEach / map function for...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-04 22:54 UTC by Piotr Popieluch
Modified: 2014-12-23 18:31 UTC (History)
2 users (show)

Fixed In Version: nodejs-async-each-0.1.6-2.fc20
Clone Of:
Environment:
Last Closed: 2014-12-19 20:06:16 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-04 22:54:10 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-async-each.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-async-each-0.1.6-1.fc21.src.rpm
Description: Async parallel forEach / map function for JavaScript
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 12:31:24 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-async-each.noarch: W: spelling-error Summary(en_US) forEach -> for Each, for-each, reach
nodejs-async-each.noarch: W: spelling-error %description -l en_US forEach -> for Each, for-each, reach
nodejs-async-each.noarch: W: only-non-binary-in-usr-lib
nodejs-async-each.src: W: spelling-error Summary(en_US) forEach -> for Each, for-each, reach
nodejs-async-each.src: W: spelling-error %description -l en_US forEach -> for Each, for-each, reach
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: bab3cb3635a44f956b685e45039c1a0311eec0d6462c684020205546a061f58c
upstream tarball:  bab3cb3635a44f956b685e45039c1a0311eec0d6462c684020205546a061f58c

+ License is "MIT" and included in its README.md file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group is optional, can be removed.

APPROVED.

Comment 2 Piotr Popieluch 2014-12-06 14:17:14 UTC
Thank you!

I will 
- remove group tag
- add rm -rf node_modules to %prep
Before pushing to scm.

Comment 3 Piotr Popieluch 2014-12-06 14:19:06 UTC
New Package SCM Request
=======================
Package Name: nodejs-async-each
Short Description: Async parallel forEach / map function for JavaScript
Upstream URL: https://github.com/paulmillr/async-each
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC: piotrp

Comment 4 Gwyn Ciesla 2014-12-08 14:15:08 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-12-13 15:25:33 UTC
nodejs-async-each-0.1.6-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-async-each-0.1.6-2.fc21

Comment 6 Fedora Update System 2014-12-13 15:25:55 UTC
nodejs-async-each-0.1.6-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-async-each-0.1.6-2.fc20

Comment 7 Fedora Update System 2014-12-13 15:27:17 UTC
nodejs-async-each-0.1.6-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-async-each-0.1.6-2.fc19

Comment 8 Fedora Update System 2014-12-15 04:27:24 UTC
nodejs-async-each-0.1.6-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2014-12-23 18:28:04 UTC
nodejs-async-each-0.1.6-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Fedora Update System 2014-12-23 18:30:10 UTC
nodejs-async-each-0.1.6-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2014-12-23 18:31:17 UTC
nodejs-async-each-0.1.6-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.