Bug 1171066 - disable_auto_scaling marker requires restart of haproxy cartridge
Summary: disable_auto_scaling marker requires restart of haproxy cartridge
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Image
Version: 2.x
Hardware: x86_64
OS: Linux
high
low
Target Milestone: ---
: 2.x
Assignee: Jakub Hadvig
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1168418
TreeView+ depends on / blocked
 
Reported: 2014-12-05 10:12 UTC by zhou ying
Modified: 2018-12-09 19:18 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1168418
Environment:
Last Closed: 2015-02-18 16:53:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 1 Jakub Hadvig 2014-12-09 12:22:38 UTC
So this is not a regression and there are two possible solutions to this issue. 

1. Properly document the 'disable_auto_scaling' marker, which should say that the gear with the ha_proxy needs to be restarted to pick-up the changes. Also would add an banner to the start script(when it detects the marker) which would say that the gear needs to be restarted, together with the command for the user.

2. Restart the ha_proxy every-time when the 'disable_auto_scaling' marker is present.

I would rather go with the first solution, cause this is not a regression and there is no point to restart the ha-proxy on every push, then the proxy doesn't make any sense.

Comment 2 Marek Mahut 2014-12-09 12:28:52 UTC
I agree, it doesn't make sense to restart haproxy at every push.

Comment 3 Ben Parees 2014-12-09 14:21:46 UTC
Agree, let's go with your solution #1.

Comment 4 openshift-github-bot 2015-01-07 18:34:20 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/e8dd080bd9ba5273fbeef2c88e1b230c13b0f604
BUG 1171066: disable_auto_scaling marker requires restart of haproxy cartridge

Comment 5 Jakub Hadvig 2015-01-07 21:57:55 UTC
Fix by properly documenting the 'disable_auto_scaling' marker and adding banner which tells user(when it detects the marker) upon deployment, that he needs to restart the gear or the whole application, in order to HAproxy can pick up the changes.

Comment 6 zhou ying 2015-01-08 05:27:50 UTC
Confirmed.The banner has been added. When restart the Haproxy or the whole app, the 'disable_auto_scaling' marker working well.

Comment 7 zhou ying 2015-01-08 09:30:29 UTC
ON devenv_5381.


Note You need to log in before you can comment on or make changes to this bug.