Bug 1171162
| Summary: | clvmd resource does not parse daemon_options correctly | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Nenad Peric <nperic> |
| Component: | resource-agents | Assignee: | Fabio Massimo Di Nitto <fdinitto> |
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.1 | CC: | agk, cluster-maint, mnovacek |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | resource-agents-3.9.5-45.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-19 04:41:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
putting quotes here around the 2nd arg would fix this as well. https://github.com/ClusterLabs/resource-agents/blob/master/heartbeat/clvm#L363 patch posted. https://github.com/ClusterLabs/resource-agents/pull/606
I have verified with clvmd in resource-agents-3.9.5-50.el7.x86_64 that
paramaters supplied with daemon_options parameter are correctly used when
starting the daemon.
---
[root@virt-151 ~]# pcs resource show clvmd
Resource: clvmd (class=ocf provider=heartbeat type=clvm)
Attributes: with_cmirrord=1
Operations: start interval=0s timeout=90 (clvmd-start-timeout-90)
stop interval=0s timeout=90 (clvmd-stop-timeout-90)
monitor interval=30s on-fail=fence (clvmd-monitor-interval-30s)
[root@virt-151 ~]# ps axf | grep clvmd
14407 pts/0 S+ 0:00 \_ grep --color=auto clvmd
7746 ? SLsl 0:00 /usr/sbin/clvmd -T90 -d0
BEFORE THE FIX (resource-agents-3.9.5-30.el7.x86_64)
---------------------------------------------------
[root@virt-151 ~]# pcs resource disable clvmd
[root@virt-151 ~]# pcs resource update clvmd daemon_options=-d2
[root@virt-151 ~]# pcs resource enable clvmd
[root@virt-151 ~]# pcs resource show clvmd
Resource: clvmd (class=ocf provider=heartbeat type=clvm)
Attributes: with_cmirrord=1 daemon_options=-d2
Operations: start interval=0s timeout=90 (clvmd-start-timeout-90)
stop interval=0s timeout=90 (clvmd-stop-timeout-90)
monitor interval=30s on-fail=fence (clvmd-monitor-interval-30s)
[root@virt-151 ~]# ps axf | grep clvmd
14407 pts/0 S+ 0:00 \_ grep --color=auto clvmd
7746 ? SLsl 0:00 /usr/sbin/clvmd -T90
AFTER THE FIX (resource-agents-3.9.5-50.el7.x86_64)
---------------------------------------------------
[root@virt-151 ~]# pcs resource disable clvmd
[root@virt-151 ~]# pcs resource update clvmd daemon_options=-d2
[root@virt-151 ~]# pcs resource enable clvmd
[root@virt-151 ~]# pcs resource show clvmd
Resource: clvmd (class=ocf provider=heartbeat type=clvm)
Attributes: with_cmirrord=1 daemon_options=-d2
Operations: start interval=0s timeout=90 (clvmd-start-timeout-90)
stop interval=0s timeout=90 (clvmd-stop-timeout-90)
monitor interval=30s on-fail=fence (clvmd-monitor-interval-30s)
[root@virt-151 ~]# ps axf | grep clvmd
14407 pts/0 S+ 0:00 \_ grep --color=auto clvmd
7746 ? SLsl 0:00 /usr/sbin/clvmd -T90 -d2
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2190.html |
Description of problem: If you define an additional daemon_options for clvmd, the options are ignored when the resource is started. Version-Release number of selected component (if applicable): resource-agents-3.9.5-38.el7.x86_64 How reproducible: Everytime Steps to Reproduce: 1. pcs resource update clvmd daemon_options=-d2 2. restart the cluster Actual results: the clvmd is started without the daemon_options Expected results: clvmd to start with any options additionally provided. Additional info: could be fixed by editing line 303 of /usr/lib/ocf/resource.d/heartbeat/clvm: local opts="${@:2}" (currently it reads only $2)