Bug 1171205 - Review Request: perl-Monitoring-Plugin - Family of modules to streamline writing plugins for various monitoring systems
Summary: Review Request: perl-Monitoring-Plugin - Family of modules to streamline writ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1171041
TreeView+ depends on / blocked
 
Reported: 2014-12-05 16:18 UTC by Petr Šabata
Modified: 2015-02-25 14:14 UTC (History)
3 users (show)

Fixed In Version: perl-Monitoring-Plugin-0.37-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-08 15:00:18 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-12-05 16:18:34 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Monitoring-Plugin/perl-Monitoring-Plugin.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Monitoring-Plugin/perl-Monitoring-Plugin-0.37-1.fc20.src.rpm
Description:
Monitoring::Plugin and its associated Monitoring::Plugin::* modules are a
family of perl modules to streamline writing Monitoring plugins. The main
end user modules are Monitoring::Plugin, providing an object-oriented
interface to the entire Monitoring::Plugin::* collection, and
Monitoring::Plugin::Functions, providing a simpler functional interface to
a useful subset of the available functionality.
Fedora Account System Username: psabata

Comment 1 Petr Šabata 2014-12-05 16:19:45 UTC
This is a replacement for Nagios::Plugin.
https://www.monitoring-plugins.org/news/new-project-name.html

Comment 2 Jitka Plesnikova 2014-12-08 09:07:37 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Monitoring-Plugin-0.37-1.fc22.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.006
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Carp)
      1 perl(Class::Accessor)
      1 perl(Class::Accessor::Fast)
      1 perl(Config::Tiny)
      1 perl(Exporter)
      1 perl(File::Basename)
      1 perl(File::Spec)
      1 perl(Getopt::Long)
      1 perl(Math::Calc::Units)
      1 perl(Monitoring::Plugin::Config)
      1 perl(Monitoring::Plugin::Functions)
      1 perl(Monitoring::Plugin::Range)
      1 perl(Monitoring::Plugin::Threshold)
      1 perl(Params::Validate)
      1 perl(base)
      1 perl(constant)
      1 perl(overload)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Monitoring-Plugin-0.37-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(Monitoring::Plugin) = 0.37
      1 perl(Monitoring::Plugin::Config)
      1 perl(Monitoring::Plugin::ExitResult)
      1 perl(Monitoring::Plugin::Functions) = 0.37
      1 perl(Monitoring::Plugin::Getopt)
      1 perl(Monitoring::Plugin::Performance)
      1 perl(Monitoring::Plugin::Range)
      1 perl(Monitoring::Plugin::Threshold)
      1 perl-Monitoring-Plugin = 0.37-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-Monitoring-Plugin.spec ./perl-Monitoring-Plugin-0.37-1.fc22.*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok


Package APPROVED.

Comment 3 Petr Šabata 2014-12-08 12:15:02 UTC
New Package SCM Request
=======================
Package Name: perl-Monitoring-Plugin
Short Description: Family of modules to streamline writing plugins for various monitoring systems
Upstream URL: http://search.cpan.org/dist/Monitoring-Plugin/
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-12-08 14:17:35 UTC
Git done (by process-git-requests).

Comment 5 Petr Šabata 2014-12-08 15:00:18 UTC
Thanks.

Comment 6 Jose Pedro Oliveira 2015-02-21 18:57:15 UTC
Hi,

Would it also be possible to have this package branched and built for EPEL6 and EPEL7? A new version of the nagios plugin check-updates is already using this perl module instead of Nagios::Plugin .

Regards,
jpo


Specfiles changes needed to build the package in EPEL and older versions of Fedora:
--- perl-Monitoring-Plugin.spec.orig	2015-02-15 00:01:23.000000000 +0100
+++ perl-Monitoring-Plugin.spec	2015-02-16 23:23:42.433089536 +0100
@@ -10,7 +10,7 @@
 BuildRequires:  perl
 BuildRequires:  perl(Config)
 BuildRequires:  perl(Cwd)
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(ExtUtils::MM_Unix)
 BuildRequires:  perl(Fcntl)
 BuildRequires:  perl(File::Find)
@@ -50,11 +50,12 @@
 %setup -q -n Monitoring-Plugin-%{version}

 %build
-perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}

 %install
 make pure_install DESTDIR=%{buildroot}
+find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
 %{_fixperms} %{buildroot}/*

 %check

Comment 7 Petr Šabata 2015-02-23 11:57:07 UTC
(In reply to Jose Pedro Oliveira from comment #6)
> Hi,
> 
> Would it also be possible to have this package branched and built for EPEL6
> and EPEL7? A new version of the nagios plugin check-updates is already using
> this perl module instead of Nagios::Plugin .
> 
> Regards,
> jpo

Feel free to request, build, and maintain the branches yourself.  I have no particular interest in EPEL myself.

Comment 8 Jose Pedro Oliveira 2015-02-24 20:48:17 UTC
Package Change Request
======================
Package Name: perl-Monitoring-Plugin
New Branches: el6 epel7
Owners: jpo
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2015-02-25 14:14:19 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.