Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-fs-ext.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-fs-ext-0.4.1-1.fc21.src.rpm Description: Extensions to core 'fs' module for Node.js Fedora Account System Username: pnemade
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-fs-ext.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-fs-ext-0.4.2-1.fc21.src.rpm Upstream now added license file
Test pass here on f21 When running fedora-review tool it gives me this rpmlint error: nodejs-fs-ext.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/fs-ext/build/fs-ext.node 0775L When I run rpmlint myself it doesn't complain about that, any idea why?? Rpmlint ------- Checking: nodejs-fs-ext-0.4.2-1.fc21.x86_64.rpm nodejs-fs-ext-0.4.2-1.fc21.src.rpm nodejs-fs-ext.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-fs-ext.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-fs-ext.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/fs-ext/build/fs-ext.node 0775L nodejs-fs-ext.x86_64: W: dangling-symlink /usr/lib/node_modules/fs-ext/node_modules/nan /usr/lib/node_modules/nan@^1 nodejs-fs-ext.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-fs-ext.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-fs-ext nodejs-fs-ext.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-fs-ext.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-fs-ext.x86_64: E: non-standard-executable-perm /usr/lib/node_modules/fs-ext/build/fs-ext.node 0775L nodejs-fs-ext.x86_64: W: dangling-symlink /usr/lib/node_modules/fs-ext/node_modules/nan /usr/lib/node_modules/nan@^1 1 packages and 0 specfiles checked; 1 errors, 3 warnings. # echo 'rpmlint-done:'
It happens that when you do packaging testing on your machine it works but we need to make sure it actually works in mock build that mean scratch build should succeed. You are right tests are working fine. I disabled them based on failure happened on my copr repository. But as scratch build worked fine on koji, let's enable them. About rpmlint error, I think we can ignore it here but good to report bug against fedora-review package. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-fs-ext.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-fs-ext-0.4.2-2.fc21.src.rpm
APPROVED
Piotr, You may want to set fedora-review+ flag not fedora-cvs+
oops, fixed
New Package SCM Request ======================= Package Name: nodejs-fs-ext Short Description: Extensions to core 'fs' module for Node.js Upstream URL: https://github.com/baudehlo/node-fs-ext/ Owners: pnemade Branches: f19 f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
nodejs-fs-ext-0.4.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-fs-ext-0.4.2-2.fc21
nodejs-fs-ext-0.4.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-fs-ext-0.4.2-2.el7
nodejs-fs-ext-0.4.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
nodejs-fs-ext-0.4.2-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-fs-ext-0.4.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.