Description of problem: Each change that is posted in the glusterfs project on Gerrit should have a BUG attached. ./rfc.sh asks for a BZ# in case it is missing in the commit message. When reviewing changes, a check if the linked bug is suitable is needed. It would be awesome if Gerrit can assist reviewers by making the 'BUG: 01234' a clickable link that points to Bugzilla. Gerrit seems to be able to support this by default, it only needs some configuration change/addition: - http://review.gluster.org/Documentation/config-gerrit.html#_a_id_commentlink_a_section_commentlink Thanks!
I think it would also be interesting to convert Change-Id's to links. This is an easy way to see a patch and all its backports.
Oh, and to Coverity CID values, like done in http://review.gluster.org/9257 .
r.g.o now has clickable links to bugzilla. I'll also add links to Coverity, if I can figure out a direct URI to the CID page. About, Change-Id's though, they are supposed to be unique to each review. So if a patch were to be backported, it would have a different Change-Id to the original.
(In reply to Kaushal from comment #3) > r.g.o now has clickable links to bugzilla. Great, thanks! > I'll also add links to Coverity, if I can figure out a direct URI to the CID > page. This seems to work: https://scan6.coverity.com:8443/query/defects.htm?projectId=10714&cid=1288824 > About, Change-Id's though, they are supposed to be unique to each review. So > if a patch were to be backported, it would have a different Change-Id to the > original. Backports often should have the same Change-Id. This makes it easy to identify backports and their original change. A Change-Id needs to be unique per branch, different branches (master, release-3.7, ...) can have the same Change-Id. Example: http://review.gluster.org/#/q/I62168a0ab4f0c78e61987371ae75a0d2dd56ced8
(In reply to Niels de Vos from comment #4) > This seems to work: > > > https://scan6.coverity.com:8443/query/defects.htm?projectId=10714&cid=1288824 > It keeps redirecting me to my coverity user dashboard. > > Backports often should have the same Change-Id. This makes it easy to > identify backports and their original change. A Change-Id needs to be unique > per branch, different branches (master, release-3.7, ...) can have the same > Change-Id. Example: > > http://review.gluster.org/#/q/I62168a0ab4f0c78e61987371ae75a0d2dd56ced8 The gerrit documentation recommends having different change-ids for backports. Each backport is a unique commit, so it should have a unique change-id for gerrit to be able to track it. This was how I thought gerrit should have worked, but apparently you can have duplicate change-ids. Whenever I've backported changes I've always had the change-id regenerated. I believe this is how most of the developers did backports. I'll add the commentlink setting anyway.
(In reply to Kaushal from comment #5) > > It keeps redirecting me to my coverity user dashboard. > I had to visit the defects view once, to get the link to work without being redirected to my dashboard. I'll add this as well.
Added linking for CIDs and Change-Ids.
The linking has been enabled for sometime and is working well. Closing this now.