Bug 1171936 - Beaker should handle shlex syntax errors more gracefully
Summary: Beaker should handle shlex syntax errors more gracefully
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: general
Version: 0.18
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: 19.3
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-09 03:20 UTC by wangdong
Modified: 2018-02-06 00:41 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-17 06:34:27 UTC
Embargoed:


Attachments (Terms of Use)

Description wangdong 2014-12-09 03:20:42 UTC
Description of problem:
Create a job with "'" single quotation. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a job and add a "'" in your recpie like this 
            ks_meta="'"
2.
3.

Actual results:
This will cause a shlex syntax error like this --> http://fpaste.org/157515/18022141/

Expected results:
Show a descriptive abort message when provisioning.

Additional info:

Comment 1 Dan Callaghan 2015-01-14 04:39:06 UTC
Current behaviour is that the job is accepted and queued but at provisioning time, it aborts with a message like this:

    Failed to provision recipeid 884, No closing quotation

Expected behaviour after this patch is that the job is not accepted, and an error message is shown like this:

    Failed to import job because of: Error parsing ks_meta: No closing quotation

http://gerrit.beaker-project.org/3932

Comment 4 Dan Callaghan 2015-03-17 06:34:27 UTC
Beaker 19.3 has been released.


Note You need to log in before you can comment on or make changes to this bug.