Spec URL: https://m4rtink.fedorapeople.org/anaconda/packaging/anaconda-user-help/anaconda-user-help.spec SRPM URL: https://m4rtink.fedorapeople.org/anaconda/packaging/anaconda-user-help/anaconda-user-help-22.1-1.fc20.src.rpm Description: This package provides content for the Anaconda built-in help system. Fedora Account System Username: m4rtink
Taking for a review.
- You should use explicit %{__python2} macro instead of plain "python" (or use %{__python3, if you can ;)) - The note about this being a Red Hat maintained package and thus source not being available seems misleading... Did you mean that tarballs are not officialy available? Otherwise the package looks good and builds, rpmlint doesn't complain, so once these two problems are fixed, I can approve.
(In reply to Bohuslav "Slavek" Kabrda from comment #2) > - You should use explicit %{__python2} macro instead of plain "python" (or > use %{__python3, if you can ;)) The build script works just fine with Python 3, so I've used the Python 3 version of the macro. :) > - The note about this being a Red Hat maintained package and thus source not > being available seems misleading... Did you mean that tarballs are not > officialy available? Ooops, looks like a copy-paste leftover - I've completely removed the note now. The source code of the help content can of course be easily obtained from the Fedora Install Guide homepage.[0] > > Otherwise the package looks good and builds, rpmlint doesn't complain, so > once these two problems are fixed, I can approve. I've updated the linked spec & srpm files with the suggested changes. [0] https://fedorahosted.org/install-guide
Looks fine now, APPROVED One minor comment - it is customary to bump the release and include changelog for changes done during the review, so please do that next time. Thanks!
(In reply to Bohuslav "Slavek" Kabrda from comment #4) > Looks fine now, APPROVED > > One minor comment - it is customary to bump the release and include > changelog for changes done during the review, so please do that next time. > Thanks! OK, thanks! :)
New Package SCM Request ======================= Package Name: anaconda-user-help Short Description: Content for the Anaconda built-in help system Upstream URL: https://fedorahosted.org/install-guide/ Owners: m4rtink Branches: f22 InitialCC: anaconda-maint
Git done (by process-git-requests).