Bug 1173082 - Alt+A doesn't mark/unmark me away
Summary: Alt+A doesn't mark/unmark me away
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: hexchat
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Patrick Griffis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-11 12:29 UTC by Milan Crha
Modified: 2015-11-24 14:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-11 13:34:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
alt-a-clash (955 bytes, patch)
2015-05-27 17:13 UTC, Milan Crha
no flags Details | Diff

Description Milan Crha 2014-12-11 12:29:23 UTC
# rpm -q hexchat
hexchat-2.10.2-1.fc21.x86_64

Using Alt+A, as shown also in menu Server->Marked Away, does nothing. Picking the menu entry works, it's only the shortcut which doesn't work. This is a regression, it used to work in Fedora 20.

Comment 1 Patrick Griffis 2014-12-11 13:34:54 UTC
This issue is tracked upstream here: https://github.com/hexchat/hexchat/issues/1008

Comment 2 Milan Crha 2015-05-27 17:13:27 UTC
Created attachment 1030714 [details]
alt-a-clash

I do not have a github account, but I hope you'll not mind if I offer you this change this way.

The problem is that the Alt+A for Mark Away clashes with a mnemonic for "Highlight _all". Changing it to another letter, like the 'H' in this patch, makes the Alt+A accelerator work.

You can try with this scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9857890

Comment 3 Patrick Griffis 2015-05-27 17:45:59 UTC
(In reply to Milan Crha from comment #2)
> Created attachment 1030714 [details]
> alt-a-clash
> 
> I do not have a github account, but I hope you'll not mind if I offer you
> this change this way.
> 
> The problem is that the Alt+A for Mark Away clashes with a mnemonic for
> "Highlight _all". Changing it to another letter, like the 'H' in this patch,
> makes the Alt+A accelerator work.
> 
> You can try with this scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=9857890

Thanks a ton! - https://github.com/hexchat/hexchat/commit/ebe1f824a7e60039ea46869e8569bdf60cfc1dda

Comment 4 Milan Crha 2015-11-06 08:20:46 UTC
Did they ever did a release with the fix, please? I updated to Fedora 23 with
   hexchat-2.10.2-4.fc23.x86_64
   gtk3-3.18.2-1.fc23.x86_64
and the Alt+A doesn't work again.

Comment 5 Patrick Griffis 2015-11-06 23:37:20 UTC
(In reply to Milan Crha from comment #4)
> Did they ever did a release with the fix, please? I updated to Fedora 23 with

There has not been a new release upstream.

Comment 6 Milan Crha 2015-11-09 11:59:24 UTC
Would you mind to carry the patch in the Fedora packages until the new release is done? It applies cleanly and fixes usability (though it's possible I'm the only one whom is missing the Alt+A shortcut).

Comment 7 Tomas 'Sheldon' Radej 2015-11-24 14:57:35 UTC
I also have this problem, and call for carrying the patch downstream until a new release is issued, please.


Note You need to log in before you can comment on or make changes to this bug.