Spec URL: https://smani.fedorapeople.org/review/qtspell.spec SRPM URL: https://smani.fedorapeople.org/review/qtspell-0.5.0-1.fc22.src.rpm Description: Spell checking for Qt text widgets Fedora Account System Username: smani
Initial review - Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)". Detailed output of licensecheck in /home/mukundan/ownCloud/pkg_reviews/1173373-qtspell/qtspell/licensecheck.txt [?]: License file installed when any subpackage combination is installed. ---> Do you mind installing the license using %license macro instead of %doc? [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/qt5/translations, /usr/share/qt5 ---> Strange. These directories are already owned by qt5-qtbase. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 2 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qtspell-qt4 , qtspell-qt4-devel , qtspell-qt5 , qtspell-qt5-devel , qtspell- qt5-translations , qtspell-doc ---> This is fine. Appropriate requires are present. qtspell-qt4-devel requires qtspell-qt4 -qt5-devel requires -qt5 -qt5-translations requires -qt5 -doc is fine. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8355560 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: qtspell-qt4-0.5.0-1.fc22.x86_64.rpm qtspell-qt4-devel-0.5.0-1.fc22.x86_64.rpm qtspell-qt5-0.5.0-1.fc22.x86_64.rpm qtspell-qt5-devel-0.5.0-1.fc22.x86_64.rpm qtspell-qt5-translations-0.5.0-1.fc22.noarch.rpm qtspell-doc-0.5.0-1.fc22.noarch.rpm qtspell-0.5.0-1.fc22.src.rpm qtspell-qt4-devel.x86_64: W: only-non-binary-in-usr-lib qtspell-qt4-devel.x86_64: W: no-documentation qtspell-qt5-devel.x86_64: W: only-non-binary-in-usr-lib qtspell-qt5-devel.x86_64: W: no-documentation qtspell-qt5-translations.noarch: W: no-documentation qtspell.src: W: invalid-url Source0: https://github.com/manisandro/qtspell/releases/download/0.5.0/qtspell-0.5.0.tar.xz HTTP Error 403: Forbidden ---> I think this is bogus. I can download it without problems from the browser. Don't know what happened here. 7 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@imladris /]# rpmlint qtspell-doc qtspell-qt4-devel qtspell-qt5-devel qtspell-qt5-translations qtspell-qt4 qtspell-qt5 qtspell-qt4-devel.x86_64: W: only-non-binary-in-usr-lib qtspell-qt5-devel.x86_64: W: only-non-binary-in-usr-lib ---> Weird ... qtspell-qt4-devel.x86_64: W: no-documentation qtspell-qt5-devel.x86_64: W: no-documentation qtspell-qt5-translations.noarch: W: no-documentation qtspell-qt4.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt4.so.0.2.0 /lib64/libgmodule-2.0.so.0 qtspell-qt4.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt4.so.0.2.0 /lib64/libglib-2.0.so.0 qtspell-qt4.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt4.so.0.2.0 /lib64/libm.so.6 qtspell-qt5.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt5.so.0.2.0 /lib64/libgmodule-2.0.so.0 qtspell-qt5.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt5.so.0.2.0 /lib64/libglib-2.0.so.0 qtspell-qt5.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqtspell-qt5.so.0.2.0 /lib64/libm.so.6 ---> Could this be fixed? 6 packages and 0 specfiles checked; 0 errors, 11 warnings. ]0;<mock-chroot><mock-chroot>[root@imladris /]# echo 'rpmlint-done:' Requires -------- qtspell-doc (rpmlib, GLIBC filtered): qtspell-qt4-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libqtspell-qt4.so.0()(64bit) qtspell-qt4(x86-64) qtspell-qt5-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libqtspell-qt5.so.0()(64bit) qtspell-qt5(x86-64) qtspell-qt5-translations (rpmlib, GLIBC filtered): qt5-qttranslations qtspell-qt5 qtspell-qt4 (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libc.so.6()(64bit) libenchant.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) qtspell-qt5 (rpmlib, GLIBC filtered): /sbin/ldconfig libQt5Core.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Widgets.so.5()(64bit) libc.so.6()(64bit) libenchant.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- qtspell-doc: qtspell-doc qtspell-qt4-devel: pkgconfig(QtSpell-qt4) qtspell-qt4-devel qtspell-qt4-devel(x86-64) qtspell-qt5-devel: pkgconfig(QtSpell-qt5) qtspell-qt5-devel qtspell-qt5-devel(x86-64) qtspell-qt5-translations: qtspell-qt5-translations qtspell-qt4: libqtspell-qt4.so.0()(64bit) qtspell-qt4 qtspell-qt4(x86-64) qtspell-qt5: libqtspell-qt5.so.0()(64bit) qtspell-qt5 qtspell-qt5(x86-64) Source checksums ---------------- https://github.com/manisandro/qtspell/releases/download/0.5.0/qtspell-0.5.0.tar.xz : CHECKSUM(SHA256) this package : fec5a8848082aedfa31114f44cb1af2e7cae4abb713bf703f6eed2860611792b CHECKSUM(SHA256) upstream package : fec5a8848082aedfa31114f44cb1af2e7cae4abb713bf703f6eed2860611792b Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 --rpm-spec -n qtspell-0.5.0-1.fc22.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Spec URL: https://smani.fedorapeople.org/review/qtspell.spec SRPM URL: https://smani.fedorapeople.org/review/qtspell-0.5.0-2.fc22.src.rpm %changelog * Fri Dec 12 2014 Sandro Mani <manisandro> - 0.5.0-2 - Use %%license - Add -Wl,--as-needed unused-direct-shlib-dependency: Seems fixed with -Wl, --as-needed qtspell.src: W: invalid-url Source0: https://github.com/manisandro/qtspell/releases/download/0.5.0/qtspell-0.5.0.tar.xz HTTP Error 403: Forbidden ---> I think this is bogus. I can download it without problems from the browser. Don't know what happened here. => Most likely the server rejecting the user agent. qtspell-qt4-devel.x86_64: W: only-non-binary-in-usr-lib qtspell-qt5-devel.x86_64: W: only-non-binary-in-usr-lib ---> Weird ... => Seing this all the time, I suppose rpmlint does not consider symlinks to be binary files (rpmlint cannot actually know that the symlinks point to binary files, since they are in another package). So this is a false positive.
All is well with the changes made. fedora-review will complain about license file because of %doc to %license. But, that's expected. Package APPROVED.
Thank you! Let me know if I can review anything in exchange. New Package SCM Request ======================= Package Name: qtspell Short Description: Spell checking for Qt text widgets Owners: smani Branches: f20 f21
Git done (by process-git-requests).
qtspell-0.5.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qtspell-0.5.0-2.fc21
qtspell-0.5.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qtspell-0.5.0-2.fc20
qtspell-0.5.0-2.fc20 has been pushed to the Fedora 20 testing repository.
qtspell-0.5.0-2.fc21 has been pushed to the Fedora 21 stable repository.
qtspell-0.5.0-2.fc20 has been pushed to the Fedora 20 stable repository.