Bug 1173378 - Review Request: osgearth - Dynamic map generation toolkit for OpenSceneGraph
Summary: Review Request: osgearth - Dynamic map generation toolkit for OpenSceneGraph
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-12 01:55 UTC by Sandro Mani
Modified: 2014-12-25 05:34 UTC (History)
2 users (show)

Fixed In Version: osgearth-2.6-3.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-25 05:32:52 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Sandro Mani 2014-12-12 01:55:12 UTC
Spec URL: https://smani.fedorapeople.org/review/osgearth.spec
SRPM URL: https://smani.fedorapeople.org/review/osgearth-2.6-1.fc22.src.rpm
Description: Dynamic map generation toolkit for OpenSceneGraph
Fedora Account System Username: smani

Note: following rpmlint errors are caused by files which are autogenerated. The empty files are referenced by links in the html files.
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/custom_driver.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/imagery.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/maps.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/elevation.txt
osgearth-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/osgearth-doc/html/_static/jquery.js
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/qt_integration.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/profile.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/annotations.txt
osgearth-doc.noarch: W: hidden-file-or-dir /usr/share/doc/osgearth-doc/html/.buildinfo

Comment 1 Zbigniew Jędrzejewski-Szmek 2014-12-12 06:33:56 UTC
Provides: bundled(jquery)

%doc → %license for LICENSE.txt

%description is too vague. Especially for -tools. What do they do?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8358023

Comment 2 Zbigniew Jędrzejewski-Szmek 2014-12-12 06:49:43 UTC
Are you sure that data/loopix/LICENSE.txt is permissible?

It seems to bundle tinyxml. Can the tinyxml package be used instead?
Same for javascript engine (v8 package)?

Comment 3 Zbigniew Jędrzejewski-Szmek 2014-12-12 06:53:14 UTC
/usr/share/doc/osgearth-doc/html/.buildinfo can be removed.

osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libosgSim.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libosgFX.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libosgGA.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libz.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libGLU.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libSM.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libICE.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libX11.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarth.so.2.5.0 /lib64/libXext.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgWidget.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgSim.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgTerrain.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgFX.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgViewer.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgText.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgGA.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libGLU.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libGL.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libSM.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libICE.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libX11.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libXext.so.6
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgShadow.so.100
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libcurl.so.4
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libgdal.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libz.so.1
osgearth.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libosgEarthSymbology.so.2.5.0 /lib64/libosgManipulator.so.100
...

Are those necessary? They inflate automatic requires a lot.

Comment 4 Sandro Mani 2014-12-12 16:09:55 UTC
Spec URL: https://smani.fedorapeople.org/review/osgearth.spec
SRPM URL: https://smani.fedorapeople.org/review/osgearth-2.6-2.fc22.src.rpm

* Fri Dec 12 2014 Sandro Mani <manisandro> - 2.6-2
- Add explicit Requires: OpenSceneGraph = %%{osg_ver}
- Add Provides: bundled(jquery) to -doc
- USe %%license for license
- Use system tinyxml, remove bundled sources
- Remove non-free loopix data
- Remove html/.buildinfo
- Add -Wl,--as-needed
- Improve descriptions
- Rename package data -> examples, put example binaries in that package


Loopix data definitely non-free, removed (don't see anything referencing them).

V8 is not bundled, it is just a C++ wrapper.

$ rpmlint osgearth
osgearth.x86_64: W: shared-lib-calls-exit /usr/lib64/libosgEarthUtil.so.2.5.0 exit.5
osgearth.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

=> -Wl,--as-needed managed to get rid of the unused dependencies.

Comment 5 Zbigniew Jędrzejewski-Szmek 2014-12-12 20:18:11 UTC
rm -f osgEarth/tinyxml*.{h,cpp} → rm -f osgEarth/tiny*

Can %{?_smp_mflags} be added to 'make -C docs html'?

I think -examples should be split into arch and noarch parts. The RPM has 91 MB, so multiplied by the number of archs this starts to matter.

Otherwise seems fine.

Comment 6 Sandro Mani 2014-12-12 20:55:48 UTC
Spec URL: https://smani.fedorapeople.org/review/osgearth.spec
SRPM URL: https://smani.fedorapeople.org/review/osgearth-2.6-3.fc22.src.rpm

%changelog
* Fri Dec 12 2014 Sandro Mani <manisandro> - 2.6-3
- Parallel build for docs
- Noarch data subpackage

Comment 7 Zbigniew Jędrzejewski-Szmek 2014-12-13 01:50:35 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable

Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE.txt in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Bogus, https://bugzilla.redhat.com/show_bug.cgi?id=1127916

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2 or later)", "GPL (unversioned/unknown version) LGPL (v2 or
     later)", "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng",
     "*No copyright* zlib/libpng". 26 files have unknown license. Detailed
     output of licensecheck in /var/tmp/1173378-osgearth/licensecheck.txt

Bogus, filed https://bugzilla.redhat.com/show_bug.cgi?id=1173740.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in osgearth-
     examples-data , osgearth-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: osgearth-2.6-3.fc22.x86_64.rpm
          osgearth-devel-2.6-3.fc22.x86_64.rpm
          osgearth-tools-2.6-3.fc22.x86_64.rpm
          osgearth-examples-2.6-3.fc22.x86_64.rpm
          osgearth-examples-data-2.6-3.fc22.noarch.rpm
          osgearth-doc-2.6-3.fc22.noarch.rpm
          osgearth-2.6-3.fc22.src.rpm
osgearth.x86_64: W: shared-lib-calls-exit /usr/lib64/libosgEarthUtil.so.2.5.0 exit.5
osgearth.x86_64: W: no-documentation
osgearth-devel.x86_64: W: only-non-binary-in-usr-lib
osgearth-devel.x86_64: W: no-documentation
osgearth-tools.x86_64: W: summary-not-capitalized C osgearth viewers and tools
osgearth-tools.x86_64: W: no-documentation
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_featureinfo
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_package_qt
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_cache
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_shadergen
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_tfs
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_backfill
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_qt
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_conv
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_version
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_atlas
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_package
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_tileindex
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_boundarygen
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_viewer
osgearth-examples.x86_64: W: summary-not-capitalized C osgearth example applications
osgearth-examples.x86_64: W: no-documentation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_map
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_shadercomp
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_sharedlayer
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_terrainprofile
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featurefilter
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_graticule
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_colorfilter
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_elevation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_manip
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_sequencecontrol
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_city
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featurequery
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_imageoverlay
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_terraineffects
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_clamp
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_occlusionculling
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_demo
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_overlayviewer
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_qt_simple
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_tilesource
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_transform
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_clipplane
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_measure
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_toc
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_tracks
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featuremanip
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_los
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_fog
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_qt_windows
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_mrt
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featureeditor
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_annotation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_minimap
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_controls
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_features
osgearth-examples-data.noarch: W: no-documentation
All acceptable.

osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/custom_driver.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/imagery.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/maps.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/elevation.txt
osgearth-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/osgearth-doc/html/_static/jquery.js
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/qt_integration.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/profile.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/annotations.txt
osgearth.src:70: W: unversioned-explicit-provides bundled(jquery)
7 packages and 0 specfiles checked; 7 errors, 60 warnings.

OK, as discussed previously.


Rpmlint (installed packages)
----------------------------
devellint osgearth-tools osgearth-examples-data osgearth-examples osgearth-doc osgearth osgearth- 
osgearth-tools.x86_64: W: summary-not-capitalized C osgearth viewers and tools
osgearth-tools.x86_64: W: no-documentation
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_featureinfo
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_package_qt
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_cache
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_shadergen
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_tfs
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_backfill
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_qt
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_conv
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_version
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_atlas
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_package
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_tileindex
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_boundarygen
osgearth-tools.x86_64: W: no-manual-page-for-binary osgearth_viewer
osgearth-examples-data.noarch: W: no-documentation
osgearth-examples.x86_64: W: summary-not-capitalized C osgearth example applications
osgearth-examples.x86_64: W: no-documentation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_map
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_shadercomp
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_sharedlayer
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_terrainprofile
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featurefilter
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_graticule
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_colorfilter
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_elevation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_manip
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_sequencecontrol
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_city
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featurequery
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_imageoverlay
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_terraineffects
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_clamp
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_occlusionculling
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_demo
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_overlayviewer
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_qt_simple
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_tilesource
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_transform
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_clipplane
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_measure
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_toc
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_tracks
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featuremanip
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_los
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_fog
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_qt_windows
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_mrt
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_featureeditor
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_annotation
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_minimap
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_controls
osgearth-examples.x86_64: W: no-manual-page-for-binary osgearth_features
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/custom_driver.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/imagery.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/maps.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/elevation.txt
osgearth-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/osgearth-doc/html/_static/jquery.js
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/developer/qt_integration.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/profile.txt
osgearth-doc.noarch: E: zero-length /usr/share/doc/osgearth-doc/html/_sources/user/annotations.txt
osgearth.x86_64: W: shared-lib-calls-exit /usr/lib64/libosgEarthUtil.so.2.5.0 exit.5
osgearth.x86_64: W: no-documentation
osgearth-devel.x86_64: W: only-non-binary-in-usr-lib
osgearth-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 7 errors, 59 warnings.
# echo 'rpmlint-done:'



Requires
--------
osgearth-tools (rpmlib, GLIBC filtered):
    libOpenThreads.so.20()(64bit)
    libQtCore.so.4()(64bit)
    libQtGui.so.4()(64bit)
    libX11.so.6()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libosg.so.100()(64bit)
    libosgDB.so.100()(64bit)
    libosgEarth.so.0()(64bit)
    libosgEarthAnnotation.so.0()(64bit)
    libosgEarthFeatures.so.0()(64bit)
    libosgEarthQt.so.0()(64bit)
    libosgEarthSymbology.so.0()(64bit)
    libosgEarthUtil.so.0()(64bit)
    libosgGA.so.100()(64bit)
    libosgText.so.100()(64bit)
    libosgViewer.so.100()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    osgearth(x86-64)
    rtld(GNU_HASH)

osgearth-examples-data (rpmlib, GLIBC filtered):
    osgearth-examples

osgearth-examples (rpmlib, GLIBC filtered):
    libOpenThreads.so.20()(64bit)
    libQtCore.so.4()(64bit)
    libQtGui.so.4()(64bit)
    libX11.so.6()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libosg.so.100()(64bit)
    libosgDB.so.100()(64bit)
    libosgEarth.so.0()(64bit)
    libosgEarthAnnotation.so.0()(64bit)
    libosgEarthFeatures.so.0()(64bit)
    libosgEarthQt.so.0()(64bit)
    libosgEarthSymbology.so.0()(64bit)
    libosgEarthUtil.so.0()(64bit)
    libosgGA.so.100()(64bit)
    libosgText.so.100()(64bit)
    libosgUtil.so.100()(64bit)
    libosgViewer.so.100()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    osgearth(x86-64)
    osgearth-examples-data
    rtld(GNU_HASH)

osgearth-doc (rpmlib, GLIBC filtered):

osgearth (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    OpenSceneGraph
    libGL.so.1()(64bit)
    libOpenThreads.so.20()(64bit)
    libQtCore.so.4()(64bit)
    libQtGui.so.4()(64bit)
    libQtOpenGL.so.4()(64bit)
    libc.so.6()(64bit)
    libcurl.so.4()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgdal.so.1()(64bit)
    libgeos-3.4.2.so()(64bit)
    libm.so.6()(64bit)
    libosg.so.100()(64bit)
    libosgDB.so.100()(64bit)
    libosgEarth.so.0()(64bit)
    libosgEarthAnnotation.so.0()(64bit)
    libosgEarthFeatures.so.0()(64bit)
    libosgEarthSymbology.so.0()(64bit)
    libosgEarthUtil.so.0()(64bit)
    libosgGA.so.100()(64bit)
    libosgManipulator.so.100()(64bit)
    libosgQt.so.100()(64bit)
    libosgShadow.so.100()(64bit)
    libosgSim.so.100()(64bit)
    libosgTerrain.so.100()(64bit)
    libosgText.so.100()(64bit)
    libosgUtil.so.100()(64bit)
    libosgViewer.so.100()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    libtinyxml.so.0()(64bit)
    rtld(GNU_HASH)

osgearth-devel (rpmlib, GLIBC filtered):
    libosgEarth.so.0()(64bit)
    libosgEarthAnnotation.so.0()(64bit)
    libosgEarthFeatures.so.0()(64bit)
    libosgEarthQt.so.0()(64bit)
    libosgEarthSymbology.so.0()(64bit)
    libosgEarthUtil.so.0()(64bit)
    osgearth(x86-64)



Provides
--------
osgearth-tools:
    osgearth-tools
    osgearth-tools(x86-64)

osgearth-examples-data:
    osgearth-examples-data

osgearth-examples:
    osgearth-examples
    osgearth-examples(x86-64)

osgearth-doc:
    bundled(jquery)
    osgearth-doc

osgearth:
    libosgEarth.so.0()(64bit)
    libosgEarthAnnotation.so.0()(64bit)
    libosgEarthFeatures.so.0()(64bit)
    libosgEarthQt.so.0()(64bit)
    libosgEarthSymbology.so.0()(64bit)
    libosgEarthUtil.so.0()(64bit)
    osgearth
    osgearth(x86-64)

osgearth-devel:
    osgearth-devel
    osgearth-devel(x86-64)



Unversioned so-files
--------------------
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_earth.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_kml.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_agglite.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_arcgis.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_arcgis_map_cache.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_bing.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_cache_filesystem.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_colorramp.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_debug.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_engine_byo.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_engine_mp.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_feature_ogr.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_feature_tfs.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_feature_wfs.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_gdal.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_label_annotation.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_label_overlay.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_mask_feature.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_model_feature_geom.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_model_feature_stencil.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_model_simple.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_noise.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_ocean_simple.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_osg.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_refresh.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_scriptengine_javascript.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_sky_gl.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_sky_simple.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_splat_mask.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_template_matclass.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_tilecache.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_tileindex.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_tileservice.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_tms.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_vdatum_egm2008.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_vdatum_egm84.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_vdatum_egm96.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_vpb.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_wcs.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_wms.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_xyz.so
osgearth: /usr/lib64/osgPlugins-3.2.1/osgdb_osgearth_yahoo.so

Source checksums
----------------
https://github.com/gwaldron/osgearth/archive/osgearth-2.6.tar.gz :
  CHECKSUM(SHA256) this package     : 965c93837520ab9538038843ff83ee1903548f8be191ee211e40abb0e6c1bb4a
  CHECKSUM(SHA256) upstream package : 965c93837520ab9538038843ff83ee1903548f8be191ee211e40abb0e6c1bb4a


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1173378
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG


Everything seems OK.

Comment 8 Sandro Mani 2014-12-13 12:50:42 UTC
Thank you! Let me know if I can review anything in exchange.

New Package SCM Request
=======================
Package Name: osgearth
Short Description: Dynamic map generation toolkit for OpenSceneGraph
Owners: smani
Branches: f20 f21

Comment 9 Gwyn Ciesla 2014-12-15 13:26:39 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-12-15 15:13:00 UTC
osgearth-2.6-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/osgearth-2.6-3.fc21

Comment 11 Fedora Update System 2014-12-15 15:13:28 UTC
osgearth-2.6-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/osgearth-2.6-3.fc20

Comment 12 Fedora Update System 2014-12-17 04:44:30 UTC
osgearth-2.6-3.fc20 has been pushed to the Fedora 20 testing repository.

Comment 13 Fedora Update System 2014-12-25 05:32:52 UTC
osgearth-2.6-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2014-12-25 05:34:27 UTC
osgearth-2.6-3.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.