Spec URL: https://spot.fedorapeople.org/jags.spec SRPM URL: https://spot.fedorapeople.org/jags-3.4.0-1.fc21.src.rpm Description: JAGS is Just Another Gibbs Sampler. It is a program for analysis of Bayesian hierarchical models using Markov Chain Monte Carlo (MCMC) simulation. Fedora Account System Username: spot Koji Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8361218
> %{_libdir}/libjrmath.so.* is a bundled lib from R with a small modification. See README in src/jrmath. A typical question with regard to bundling is: has anything been done to get this change included in the current API of R's math lib? > libltdl/* is a bundled libtool dlopen lib. It is compiled but not linked with. Getting upstream configure script to disable this bundled lib, so it could be deleted and would not be compiled/linked with accidentally, would be a good thing. > Patch0: JAGS-3.4.0-fix-fsf-address.patch It patches file COPYING. Please clarify the following: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address | The license file, usually COPYING, must not be patched for legal reasons.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
6-year-old unreviewed package submission? LET'S DO THIS. New Spec URL: https://spot.fedorapeople.org/jags.spec New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-1.fc33.src.rpm Koji (Rawhide) Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=46961181 Fedora Account Name: spot Who wants to be a necromancer and revive this from the dead?
The mock build made by fedora-review fails: + cp -pr doc/manual/jags_developer_manual.pdf /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel cp: cannot stat 'doc/manual/jags_developer_manual.pdf': No such file or directory + : + RPM_EC=0 ++ jobs -p + exit 0 error: File not found: /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel/jags_developer_manual.pdf RPM build errors: File not found: /builddir/build/BUILDROOT/jags-4.3.0-1.fc33.x86_64/usr/share/doc/jags-devel/jags_developer_manual.pdf Child return code was: 1 Also, the License tag value (GPL+) doesn't seem to be correct, the project homepage says it's GPLv2.
Well, that's weird. Not sure why mock would fail when koji succeeds. I can reproduce it though, but only in mock with --isolation=nspawn: pdflatex: fatal: Could not undump 233630 8-byte item(s) from /builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt. mktexfmt [INFO]: /builddir/.texlive2020/texmf-var/web2c/pdftex/pdflatex.fmt installed. make[2]: *** [Makefile:674: jags_developer_manual.pdf] Error 1 When I run mock with --isolation=simple, it works as expected. Perhaps that's what koji uses? License tag fixed in -2. New Spec URL: https://spot.fedorapeople.org/jags.spec New SRPM URL: https://spot.fedorapeople.org/jags-4.3.0-2.fc33.src.rpm
The above error is also returned in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47631095 I suspect this is triggered randomly, since in your previous Koji scratch build that didn't happen (also, this last time is jags_user_manual.pdf which triggers the error).
Very strange. Looks like there is a timing issue in texlive somewhere. I can disable doc generation if you think it is necessary to complete the review, but I suspect it may just take a few build attempts to get a success on all arches.
Fine then, I ran some manual checks since fedora-review is unable to perform them and everything seems ok, just beware about using a glob when listing shared libraries: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files package APPROVED
The original reporter account has been disabled, marking this as DEADREVIEW.