Bug 1173712 - Automate : Locked domains can be deleted
Summary: Automate : Locked domains can be deleted
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.4.0
Assignee: Harpreet Kataria
QA Contact: Aziza Karol
URL:
Whiteboard:
Depends On:
Blocks: 1176202
TreeView+ depends on / blocked
 
Reported: 2014-12-12 18:26 UTC by Shveta
Modified: 2015-06-16 12:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1176202 (view as bug list)
Environment:
Last Closed: 2015-06-16 12:46:24 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
domain delete (84.00 KB, image/png)
2014-12-12 18:26 UTC, Shveta
no flags Details
Simulation (82.75 KB, image/png)
2014-12-12 18:28 UTC, Shveta
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Shveta 2014-12-12 18:26:06 UTC
Created attachment 967776 [details]
domain delete

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Automate -- Explorer 
2. Locked domains like ManageIQ and Redhat cannot be edited but can be deleted.
3.

Actual results:


Expected results:


Additional info:
5.3.1.10.20141112120709_c36c424

Comment 1 Shveta 2014-12-12 18:28:04 UTC
Created attachment 967777 [details]
Simulation

After deleting Locked domains .. simulation page goes blank

Comment 3 Greg McCullough 2014-12-18 20:11:59 UTC
Madhu - Can we protect this in the back-end raise an error?  We will still have to allow the domains to be removed as part of the reset_to_defaults and maybe other places.

We can also look at protecting this from the UI.

Comment 4 mkanoor 2014-12-18 21:21:14 UTC
This looks like a UI issue passing it to Harpreet

Comment 5 CFME Bot 2014-12-22 22:30:57 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/09117a1ba0a577288be36a2715d3bcb4c1e7eae5

commit 09117a1ba0a577288be36a2715d3bcb4c1e7eae5
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 19 11:49:26 2014 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Dec 19 14:42:36 2014 -0500

    Fixed code to not allow deletion of locked domains.
    
    Added spec test to verify fixed code.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1173712
    https://bugzilla.redhat.com/show_bug.cgi?id=1176202

 vmdb/app/controllers/miq_ae_class_controller.rb       | 10 +++++++++-
 vmdb/spec/controllers/miq_ae_class_controller_spec.rb | 19 +++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2014-12-22 22:31:04 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/cdd0d1f284793a239bbbcfce223a1d68eb8e371e

commit cdd0d1f284793a239bbbcfce223a1d68eb8e371e
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 19 16:47:49 2014 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Dec 22 16:11:44 2014 -0500

    Fixed 4 occurrences of "can not" to "cannot".
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1173712
    https://bugzilla.redhat.com/show_bug.cgi?id=1176202

 vmdb/app/controllers/miq_ae_class_controller.rb       | 8 +++++---
 vmdb/spec/controllers/miq_ae_class_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 7 CFME Bot 2015-01-06 16:11:18 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=ab8b59a42778a195a5a71b01269d5550b1334dab

commit ab8b59a42778a195a5a71b01269d5550b1334dab
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 19 11:49:26 2014 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jan 6 11:09:07 2015 -0500

    Fixed code to not allow deletion of locked domains.
    
    Added spec test to verify fixed code.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1173712
    https://bugzilla.redhat.com/show_bug.cgi?id=1176202
    (cherry picked from commit 09117a1)

 vmdb/app/controllers/miq_ae_class_controller.rb       | 10 +++++++++-
 vmdb/spec/controllers/miq_ae_class_controller_spec.rb | 19 +++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

Comment 8 CFME Bot 2015-01-06 16:11:29 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a856c50ad09d83cead6020fe0e62de1cd72f96d1

commit a856c50ad09d83cead6020fe0e62de1cd72f96d1
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 19 16:47:49 2014 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jan 6 11:09:07 2015 -0500

    Fixed 4 occurrences of "can not" to "cannot".
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1173712
    https://bugzilla.redhat.com/show_bug.cgi?id=1176202
    (cherry picked from commit cdd0d1f)

 vmdb/app/controllers/miq_ae_class_controller.rb       | 12 +++++-------
 vmdb/spec/controllers/miq_ae_class_controller_spec.rb |  2 +-
 2 files changed, 6 insertions(+), 8 deletions(-)

Comment 9 Aziza Karol 2015-02-02 09:59:00 UTC
Fixed. Locked Domains cannot be deleted.

upstream verified:
master.20150131061928_597806a

Comment 11 errata-xmlrpc 2015-06-16 12:46:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.