Bug 1173723 - content-override does not produce an error when --label is missing
Summary: content-override does not produce an error when --label is missing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: Nightly
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Christine Fouant
QA Contact: jcallaha
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks: 1188305
TreeView+ depends on / blocked
 
Reported: 2014-12-12 18:50 UTC by jcallaha
Modified: 2017-02-23 20:43 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-12 05:20:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 8892 0 None None None 2016-04-22 16:18:28 UTC
Red Hat Product Errata RHSA-2015:1592 0 normal SHIPPED_LIVE Important: Red Hat Satellite 6.1.1 on RHEL 6 2015-08-12 09:04:35 UTC

Description jcallaha 2014-12-12 18:50:17 UTC
Description of problem: 
when running activation-key content-override, you must include the label of the product being overridden. However, a user can currently run content-override without passing --label. Of course, no change is made.


Version-Release number of selected component (if applicable):
Nightly


How reproducible:
always


Steps to Reproduce:
1. create an activation key and add a subscription
2. run hammer -u admin -p **** activation-key content-override --id=<activation key id> --organization-id=<organization id>
3. view results


Actual results:
Command runs and returns "Updated content override"


Expected results:
An error should be returned informing the user that a product label is needed.


Additional info:

Comment 1 RHEL Program Management 2014-12-12 19:04:28 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Christine Fouant 2015-01-09 18:23:36 UTC
Created redmine issue http://projects.theforeman.org/issues/8892 from this bug

Comment 4 Christine Fouant 2015-02-11 15:41:57 UTC
*** Bug 1187750 has been marked as a duplicate of this bug. ***

Comment 5 Bryan Kearney 2015-02-25 17:04:41 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/8892 has been closed
-------------
Christine Fouant
Applied in changeset commit:katello|bc66876163e0cd5f6ccaaaf7223f990147aea9d5.

Comment 8 Tazim Kolhar 2015-03-09 08:57:55 UTC
FAILEDQA :

# rpm -qa | grep foreman
foreman-1.7.2.8-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.2-1.el6_6sat.noarch
foreman-compute-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_docker-1.2.0.2-1.el6_6sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el6_6sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.1-1.el6_6sat.noarch
foreman-proxy-1.7.2.3-1.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-client-1.0-1.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-client-1.0-1.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.5-1.el6_6sat.noarch
foreman-vmware-1.7.2.8-1.el6_6sat.noarch
foreman-libvirt-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_abrt-0.0.5-2.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-1.0-2.noarch
rubygem-hammer_cli_foreman-0.1.4.6-1.el6_6sat.noarch
foreman-selinux-1.7.2.8-1.el6_6sat.noarch
foreman-debug-1.7.2.8-1.el6_6sat.noarch
foreman-gce-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman-redhat_access-0.0.8-2.el6_6sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.5-1.el6_6sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el6_6sat.noarch
foreman-postgresql-1.7.2.8-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.3-1.el6_6sat.noarch
foreman-ovirt-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.8-1.el6_6sat.noarch

 hammer -u admin -p changeme activation-key content-override --id 75 --organization 1 --content-label 'Busybox' --value 0
Could not update content override:
  Invalid content label: Busybox

Comment 9 Christine Fouant 2015-03-09 15:24:18 UTC
This looks like the bug wasn't tested correctly. Moving back to ON_QA.

Comment 10 jcallaha 2015-03-09 15:32:53 UTC
Verified in Satellite 6.1.0 snap 5.

Version tested:
RHEL 66
RHEL 7


# hammer -u admin -p **** activation-key content-override --content-label=rhel-7-server-satellite-6.0-rpms --value=0 --id=3 --organization-id=12
Updated content override

Comment 11 Bryan Kearney 2015-08-11 13:20:50 UTC
This bug is slated to be released with Satellite 6.1.

Comment 12 errata-xmlrpc 2015-08-12 05:20:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592


Note You need to log in before you can comment on or make changes to this bug.