Spec URL: https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms.spec SRPM URL: https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms-1.5-1.fc21.src.rpm Description: Wikitcms is a library for interacting with Fedora's wiki-based 'test management' system and creating the pages for various types of test event. Fedora Account System Username: adamwill
Latest spec is now at the same URL, latest SRPM is https://www.happyassassin.net/wikitcms/repo/21/SRPMS/python-wikitcms-1.8.3-1.fc21.src.rpm .
Pete: thanks a lot! Current python-wikitcms depends on fedfind, so I need to file a package review for that first. I'll file that one and update this and the relval review soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1194428 is the fedfind review request. https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms.spec is updated to the latest version of python-wikitcms - 1.10.2 - and the new .src.rpm link is: https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms-1.10.2-1.fc23.src.rpm . Thanks a lot!
Will you update this for the latest version of python-wikitcms, please?
there was no point doing so till fedfind got approved, since it depends on fedfind. I'll update it tomorrow.
https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms.spec https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms-1.11.4-1.fc22.src.rpm
https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms.spec https://www.happyassassin.net/reviews/python-wikitcms/python-wikitcms-1.12-1.fc23.src.rpm ping?
pong, feedback coming today or tomorrow.
Hey Adam, everything is in order here: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed [+] = Manual review pass [N] = Manual review NEEDSWORK Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [+]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [+]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /srv/projects/fedpkg/1173797-python-wikitcms/licensecheck.txt [+]: Package contains no bundled libraries without FPC exception. [+]: Changelog in prescribed format. [+]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required ## I know this is going in EPEL, carry on. [+]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [+]: Package uses nothing in %doc for runtime. [+]: Package consistently uses macros (instead of hard-coded directory names). [+]: Package is named according to the Package Naming Guidelines. [+]: Package does not generate any conflict. [+]: Package obeys FHS, except libexecdir and /usr/target. [+]: If the package is a rename of another package, proper Obsoletes and Provides are present. [+]: Requires correct, justified where necessary. [+]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [+]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [+]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [+]: Python eggs must not download any dependencies during the build process. [+]: A package which is used by another package via an egg interface should provide egg info. [+]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]: Final provides and requires are sane (see attachments). [+]: Package functions as described. [+]: Latest version is packaged. [+]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [+]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [+]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-wikitcms-1.12-1.fc21.noarch.rpm python-wikitcms-1.12-1.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-wikitcms (rpmlib, GLIBC filtered): python(abi) python-mwclient python2-cached_property python2-fedfind Provides -------- python-wikitcms: python-wikitcms Source checksums ---------------- https://www.happyassassin.net/wikitcms/releases/wikitcms-1.12.tar.xz : CHECKSUM(SHA256) this package : f54fd91ee1bf2ddf43c0615fd2d26715622fa1ce29fa7a69d7a8cdc81e98b052 CHECKSUM(SHA256) upstream package : f54fd91ee1bf2ddf43c0615fd2d26715622fa1ce29fa7a69d7a8cdc81e98b052 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1173797 Buildroot used: fedora-21-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 =================================== Package is APPROVED.
Thanks! Thought I'd updated all my specs for %license, obviously missed this one, I'll fix it on import.
New Package SCM Request ======================= Package Name: python-wikitcms Short Description: Fedora QA wiki test management Python library Upstream URL: https://www.happyassassin.net/wikitcms Owners: adamwill Branches: f21 f22 f23 epel7 InitialCC:
Git done (by process-git-requests).
I've done builds and updates now.