Bug 1174126

this bugs weren't included in the 3.5.1 tracker, hence not marked as critical to the version. 3.5.1 was done and already has a high number of bugs, so postponing this to 3.5.2

this was already included in 3.5.1, the bug wasn't updated, sorry

If this bug requires doc text for errata release, please provide draft text in the doc text field in the following format:

Cause:
Consequence:
Fix:
Result:

The documentation team will review, edit, and approve the text.

If this bug does not require doc text, please set the 'requires_doc_text' flag to -.

Not fixed, verified using vt14.1 (rhevm-3.5.1-0.2.el6ev)
Scenario:
1. edit /etc/ovirt-engine/osinfo.conf.d/00-defaults.properties 
and change line: os.other.bus.value = 32 to os.other.bus.value = 1234
2. restart ovirt-engine service.
Actual results:
- java exception occurs (Error during initialization: java.lang.RuntimeException: osinfo properties syntax error: /etc/ovirt-engine/
osinfo.conf.d/00-defaults.properties: 49, 21: error: Encountered " <INT> "1234 "" at line 49, column 22.)
- 00-defaults.properties file is not overwritten with default file.
- Engine UI is inaccessible, no profiles (such as internal) in login page profile dropbox

engine logs is 00-defaults.properties file attached, see 1174126_reproduce.tgz

Created attachment 1005392 [details]
reopen logs.

As i understand from dev team, in case of RuntimeException on this file, the engine should not continue with loading process, which is not the current behavior (please ignore what i wrote in comment 4 "00-defaults.properties file is not overwritten with default file").

update - this is working with jboss-as 7.1.1 but not with jboss EAP 6.3
(error is thrown but backend continue loading), checking for a solution for this

this would need to be postponed until this is fixed in jboss,
currently planned to be on the first 6.4.z release

Moved to 3.5.4 to align with JBoss 6.4.z

should be tested once jboss 6.4.1 is out (soon)

The underlying issue is already fixed in JBoss EAP 6.4.1. There is no change to do in the engine.

Not Fixed.
1. RHEVM Version: 3.5.3-0.2.el6ev 
2. Jboss build: #grep EAP /var/log/ovirt-engine/server.log
JBoss EAP 6.4.1.GA (AS 7.5.1.Final-redhat-2)
Testing procedure:
1. Change /etc/ovirt-engine/osinfo.conf.d/00-defaults.properties
   os.other.bus.value from 64 to 6444
2. Restart ovirt-engine service
Actual result: 
Engine is running although the next exception occurs: 
2015-05-27 10:50:50,602 ERROR [org.ovirt.engine.core.bll.Backend] (ServerService Thread Pool -- 44) Error during initialization: java.lang.RuntimeException: osinfo properties syntax error: /etc/ovirt-engine/o
sinfo.conf.d/00-defaults.properties: 49, 21: error: Encountered " <INT> "6444 "" at line 49, column 22.

Also, grep EAP /var/log/ovirt-engine/server.log retrieve:
2015-05-27 10:50:51,861 ERROR [org.jboss.as] (Controller Boot Thread) JBAS015875: JBoss EAP 6.4.1.GA (AS 7.5.1.Final-redhat-2) started (with errors) in 25726ms - Started 1240 of 1258 services (6 services failed or missing dependencies, 68 services are lazy, passive or on-demand)

Server log attached (server.log05272015)

Created attachment 1030392 [details]
server.log05272015

Vaclav, how can i verify the jboss fix is indeed in this version?
when we applied the fix manually in development it worked (patched EAP 6.3)

What happened before the fix to JBoss EAP is that the application server swallowed the error and deployed the application, but in an state that made it work incorrectly. What was expected from this fix is that the application isn't deployed at all. This is what happens now, the error is detected and the application deployment is rolled back, as demonstrated by the following server.log:

2015-05-27 10:50:52,690 INFO  [org.jboss.as.server] (DeploymentScanner-threads - 2) JBAS015858: Undeployed "engine.ear" (runtime-name: "engine.ear")

That is what was expected, so I think that this bug is fixed.

Note that currently we don't have the ability to detect deployment failures like this and fail the start-up of the application server. That may be the subject of a different bug or RFE.

Thanks Juan and Vaclav!
Nissim please try to verify again that the engine does not load and you cannot access the portals with a broken osInfo.

Thanks.

Verified. After the next ERROR occurs, application deployment stopped:
2015-06-08 17:36:16,539 ERROR [org.ovirt.engine.core.bll.Backend] (ServerService Thread Pool -- 55) Error during initialization: java.lang.RuntimeException: osinfo properties syntax error: /etc
/ovirt-engine/osinfo.conf.d/00-defaults.properties: 49, 21: error: Encountered " <INT> "6411 "" at line 49, column 22.
Was expecting one of:
    <WS> ...
    <BUS_WIDTH> ...

RHEV 3.5.4 Released. closing current release.