Spec URL: http://puiterwijk.fedorapeople.org//ipsilon.spec SRPM URL: http://puiterwijk.fedorapeople.org//ipsilon-0.3.0-1.fc21.src.rpm Description: Ipsilon is a multi-protocol Identiy Provider service. Its function is to bridge authentication providers and applications to achieve Single Sign On and Federation.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8395432
Fix shebang removal New Spec URL: http://puiterwijk.fedorapeople.org//ipsilon.spec New SRPM URL: http://puiterwijk.fedorapeople.org//ipsilon-0.3.0-2.fc21.src.rpm
Original review as discussed over IRC: Items that need work: - Subpackage dependencies must be fixed. The providers should each have an explicit Requires on the base ipsilon package. - The base package should own correct directories where applicable. Note: Directories without known owners: /usr/share/ipsilon, /usr/share/ipsilon/ui, /usr/lib/python2.7/site-packages/ipsilon/info, /usr/lib/python2.7/site-packages/ipsilon, /usr/share/ipsilon/templates/install, /usr/lib/python2.7/site- packages/ipsilon/providers, /usr/share/ipsilon/templates/login, /usr/lib/python2.7/site-packages/ipsilon/login, /usr/share/ipsilon/templates - Please provide links to FPC tickets for temporary bundling exceptions for javascript resources. - One spelling error (s/agaist/against/). ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in /home/threebean/1174650-ipsilon/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ipsilon, /usr/share/ipsilon/ui, /usr/lib/python2.7/site-packages/ipsilon/info, /usr/lib/python2.7/site-packages/ipsilon, /usr/share/ipsilon/templates/install, /usr/lib/python2.7/site- packages/ipsilon/providers, /usr/share/ipsilon/templates/login, /usr/lib/python2.7/site-packages/ipsilon/login, /usr/share/ipsilon/templates [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. (subpackage deps) [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see the subpackage deps question) [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ipsilon- tools , ipsilon-saml2 , ipsilon-openid , ipsilon-persona , ipsilon- authfas , ipsilon-authpam , ipsilon-authkrb , ipsilon-authldap [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ipsilon-0.3.0-1.fc22.noarch.rpm ipsilon-tools-0.3.0-1.fc22.noarch.rpm ipsilon-saml2-0.3.0-1.fc22.noarch.rpm ipsilon-openid-0.3.0-1.fc22.noarch.rpm ipsilon-persona-0.3.0-1.fc22.noarch.rpm ipsilon-authfas-0.3.0-1.fc22.noarch.rpm ipsilon-authpam-0.3.0-1.fc22.noarch.rpm ipsilon-authkrb-0.3.0-1.fc22.noarch.rpm ipsilon-authldap-0.3.0-1.fc22.noarch.rpm ipsilon-0.3.0-1.fc22.src.rpm ipsilon.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti ipsilon.noarch: W: non-standard-uid /var/lib/ipsilon ipsilon ipsilon.noarch: W: non-standard-gid /var/lib/ipsilon ipsilon ipsilon.noarch: E: non-standard-dir-perm /var/lib/ipsilon 0700L ipsilon.noarch: W: non-standard-uid /etc/ipsilon ipsilon ipsilon.noarch: W: non-standard-gid /etc/ipsilon ipsilon ipsilon.noarch: E: non-standard-dir-perm /etc/ipsilon 0700L ipsilon.noarch: W: no-manual-page-for-binary ipsilon-server-install ipsilon-tools.noarch: W: no-manual-page-for-binary ipsilon-client-install ipsilon-saml2.noarch: W: no-documentation ipsilon-openid.noarch: W: no-documentation ipsilon-persona.noarch: W: no-documentation ipsilon-authfas.noarch: W: spelling-error %description -l en_US agaist -> against, ageist, again ipsilon-authfas.noarch: W: no-documentation ipsilon-authpam.noarch: W: spelling-error %description -l en_US agaist -> against, ageist, again ipsilon-authpam.noarch: W: no-documentation ipsilon-authkrb.noarch: W: spelling-error Summary(en_US) auth -> auto, Ruth, author ipsilon-authkrb.noarch: W: spelling-error Summary(en_US) kerb -> berk, herb, verb ipsilon-authkrb.noarch: W: summary-not-capitalized C mod_auth_kerb based login plugin ipsilon-authkrb.noarch: W: spelling-error %description -l en_US auth -> auto, Ruth, author ipsilon-authkrb.noarch: W: spelling-error %description -l en_US kerb -> berk, herb, verb ipsilon-authkrb.noarch: W: no-documentation ipsilon-authldap.noarch: W: spelling-error Summary(en_US) auth -> auto, Ruth, author ipsilon-authldap.noarch: W: spelling-error Summary(en_US) kerb -> berk, herb, verb ipsilon-authldap.noarch: W: summary-not-capitalized C mod_auth_kerb based login plugin ipsilon-authldap.noarch: W: no-documentation ipsilon.src: W: spelling-error %description -l en_US multi -> mulch, mufti 10 packages and 0 specfiles checked; 2 errors, 25 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@geier /]# rpmlint ipsilon-authkrb ipsilon-authfas ipsilon-persona ipsilon-authldap ipsilon-tools ipsilon-authpam ipsilon-saml2 ipsilon ipsilon-openid ipsilon-authkrb.noarch: W: spelling-error Summary(en_US) auth -> auto, Ruth, author ipsilon-authkrb.noarch: W: spelling-error Summary(en_US) kerb -> berk, herb, verb ipsilon-authkrb.noarch: W: summary-not-capitalized C mod_auth_kerb based login plugin ipsilon-authkrb.noarch: W: spelling-error %description -l en_US auth -> auto, Ruth, author ipsilon-authkrb.noarch: W: spelling-error %description -l en_US kerb -> berk, herb, verb ipsilon-authkrb.noarch: W: no-documentation ipsilon-authfas.noarch: W: spelling-error %description -l en_US agaist -> against, ageist, again ipsilon-authfas.noarch: W: no-documentation ipsilon-persona.noarch: W: no-documentation ipsilon-authldap.noarch: W: spelling-error Summary(en_US) auth -> auto, Ruth, author ipsilon-authldap.noarch: W: spelling-error Summary(en_US) kerb -> berk, herb, verb ipsilon-authldap.noarch: W: summary-not-capitalized C mod_auth_kerb based login plugin ipsilon-authldap.noarch: W: no-documentation ipsilon-tools.noarch: W: no-manual-page-for-binary ipsilon-client-install ipsilon-authpam.noarch: W: spelling-error %description -l en_US agaist -> against, ageist, again ipsilon-authpam.noarch: W: no-documentation ipsilon-saml2.noarch: W: no-documentation ipsilon.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti ipsilon.noarch: W: non-standard-uid /var/lib/ipsilon ipsilon ipsilon.noarch: W: non-standard-gid /var/lib/ipsilon ipsilon ipsilon.noarch: E: non-standard-dir-perm /var/lib/ipsilon 0700L ipsilon.noarch: W: non-standard-uid /etc/ipsilon ipsilon ipsilon.noarch: W: non-standard-gid /etc/ipsilon ipsilon ipsilon.noarch: E: non-standard-dir-perm /etc/ipsilon 0700L ipsilon.noarch: W: no-manual-page-for-binary ipsilon-server-install ipsilon-openid.noarch: W: no-documentation 9 packages and 0 specfiles checked; 2 errors, 24 warnings. ]0;<mock-chroot><mock-chroot>[root@geier /]# echo 'rpmlint-done:' Requires -------- ipsilon-authkrb (rpmlib, GLIBC filtered): mod_auth_kerb python(abi) ipsilon-authfas (rpmlib, GLIBC filtered): python(abi) python-fedora ipsilon-persona (rpmlib, GLIBC filtered): m2crypto python(abi) ipsilon-authldap (rpmlib, GLIBC filtered): python(abi) python-ldap ipsilon-tools (rpmlib, GLIBC filtered): /usr/bin/python lasso-python mod_auth_mellon python(abi) python-lxml python-requests ipsilon-authpam (rpmlib, GLIBC filtered): python(abi) python-pam ipsilon-saml2 (rpmlib, GLIBC filtered): lasso-python python(abi) ipsilon (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python /usr/sbin/restorecon /usr/sbin/semanage ipsilon-provider ipsilon-tools mod_intercept_form_submit mod_wsgi python(abi) python-cherrypy python-jinja2 python-lxml python-sqlalchemy shadow-utils ipsilon-openid (rpmlib, GLIBC filtered): python(abi) python-openid python-openid-cla python-openid-teams Provides -------- ipsilon-authkrb: ipsilon-authkrb ipsilon-authfas: ipsilon-authfas ipsilon-persona: ipsilon-persona ipsilon-provider ipsilon-authldap: ipsilon-authldap ipsilon-tools: ipsilon-tools ipsilon-authpam: ipsilon-authpam ipsilon-saml2: ipsilon-provider ipsilon-saml2 ipsilon: ipsilon ipsilon-openid: ipsilon-openid ipsilon-provider Source checksums ---------------- https://fedorahosted.org/released/ipsilon/ipsilon-0.3.0.tar.gz : CHECKSUM(SHA256) this package : 2d27e25ea23a4babb37ec3c2d663cc797e824870b514a81860ecda5955ff5fa1 CHECKSUM(SHA256) upstream package : 2d27e25ea23a4babb37ec3c2d663cc797e824870b514a81860ecda5955ff5fa1 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1174650 --mock-config fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
- Fix typo - Add comments on why the test suite is not in check - The subpackages require the base package - Add link to FPC ticket for bundling exception request New Spec URL: http://puiterwijk.fedorapeople.org//ipsilon.spec New SRPM URL: http://puiterwijk.fedorapeople.org//ipsilon-0.3.0-3.fc21.src.rpm
Package is APPROVED.
New Package SCM Request ======================= Package Name: ipsilon Short Description: An Identity Provider Server Upstream URL: https://fedorahosted.org/ipsilon/ Owners: puiterwijk simo Branches: f21 epel7 InitialCC:
Thanks for reviewing!
Git done (by process-git-requests).
ipsilon-0.3.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ipsilon-0.3.0-3.fc21
ipsilon-0.3.0-3.fc21 has been pushed to the Fedora 21 testing repository.
ipsilon-0.3.0-3.fc21 has been pushed to the Fedora 21 stable repository.