DescriptionYedidyah Bar David
2014-12-16 10:02:21 UTC
Description of problem:
Version-Release number of selected component (if applicable):
How reproducible:
always
Steps to Reproduce:
1. install and setup engine on machine A
2. install and setup dwh (or reports, or both) on machine B
3. install engine on machine B
4. Run engine-setup
Actual results:
it will automatically enable the engine without asking 'Configure engine?'.
Expected results:
At least ask, better prevent.
Additional info:
Current code [1] (simplified a bit for bugzilla) is:
if engine_enabled is None:
if not engine_db_is_new:
engine_enabled = True
else:
ask
When step 4 above is ran:
- engine_enabled is none (not set anywhere, defaults to none)
- engine_db_is_new is False, because the previous run (step 2) already connected to it, checked that it's not new, and kept the answer in the postinstall file
We need to somehow identify the current situation (engine _is_ enabled, but on a remote host) and prevent configuring it. I do not think it's a reasonable flow to add an engine after dwh (or reports) is already set up with remote engine, even though it might work in principle (and discussed and rejected during the design discussions for dwh/reports on separate hosts).
[1] packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py:_customization
Description of problem: Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. install and setup engine on machine A 2. install and setup dwh (or reports, or both) on machine B 3. install engine on machine B 4. Run engine-setup Actual results: it will automatically enable the engine without asking 'Configure engine?'. Expected results: At least ask, better prevent. Additional info: Current code [1] (simplified a bit for bugzilla) is: if engine_enabled is None: if not engine_db_is_new: engine_enabled = True else: ask When step 4 above is ran: - engine_enabled is none (not set anywhere, defaults to none) - engine_db_is_new is False, because the previous run (step 2) already connected to it, checked that it's not new, and kept the answer in the postinstall file We need to somehow identify the current situation (engine _is_ enabled, but on a remote host) and prevent configuring it. I do not think it's a reasonable flow to add an engine after dwh (or reports) is already set up with remote engine, even though it might work in principle (and discussed and rejected during the design discussions for dwh/reports on separate hosts). [1] packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py:_customization