Bug 1174933 - Review Request: python-rq - Library for creating background jobs, and processing them.
Summary: Review Request: python-rq - Library for creating background jobs, and process...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2014-12-16 19:20 UTC by Daniel Bruno
Modified: 2020-08-10 00:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:50:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Daniel Bruno 2014-12-16 19:20:21 UTC
Spec URL: https://dbruno.fedorapeople.org/python-rq/python-rq.spec
SRPM URL: https://dbruno.fedorapeople.org/python-rq/python-rq-0.4.6-1.fc21.src.rpm
Description: RQ (Redis Queue) is a simple Python library for queueing jobs and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry.
Fedora Account System Username: dbruno

Comment 1 Niranjan Mallapadi Raghavender 2014-12-23 00:16:11 UTC
This is un-official review of the package. 

The source cannot be downloaded.

INFO: Getting .spec and .srpm Urls from : 1174933
INFO:   --> SRPM url: https://dbruno.fedorapeople.org/python-rq/python-rq-0.4.6-1.fc21.src.rpm
INFO:   --> Spec url: https://dbruno.fedorapeople.org/python-rq/python-rq.spec
INFO: Using review directory: /home/makerpm/rpmbuild/SPECS/1174933-python-rq
INFO: Downloading .spec and .srpm files
INFO: No upstream for (Source2): README-pythonrq.md
INFO: Downloading (Source0): http://pypi.python.org/packages/source/a/apache-libcloud/rq-0.4.6.tar.gz
WARNING: Cannot download url: http://pypi.python.org/packages/source/a/apache-libcloud/rq-0.4.6.tar.gz
INFO: No upstream for (Source0): rq-0.4.6.tar.gz
INFO: No upstream for (Source1): LICENSE-pythonrq

Comment 2 Miroslav Suchý 2014-12-27 13:24:21 UTC
Just reading the 

This:
  %clean
  rm -rf %{buildroot}

Is not needed unless you target EL5.
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
The same apply for 
  rm -rf %{buildroot}
in
  %install

Fedora 22 defaults to Python3. Unless you have strong reason, you should provide python3-* subpackage.

This:
  %defattr(-,root,root,-)
is default and is not needede since rpm4.2

It would be nice if you can provide man pages for:
  %{_bindir}/rqinfo
  %{_bindir}/rqworker
(and maybe contribute it back to upstream).

License should be:
%license LICENSE

Upstream have tests... you should run them in %check section. (you need to package them as SOURCEX)

in %prep section you should delete bundled egg-info and create it from source
http://fedoraproject.org/wiki/Packaging:Python_Eggs

You should try to preserve timestamps of files. Therefore you "cp -a".

Summary must not end with dot.

Buildroot tag is not needed (unless you target el5)
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Comment 3 Package Review 2020-07-10 00:51:08 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Package Review 2020-08-10 00:50:32 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.