Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou-5.1.1-1.fc21.src.rpm Description: A dedicated KDE search application built on top of Baloo Fedora Account System Username: jgrulich
Naming: OK (mostly) (I think I'd prefer to simply call this "milou", without the artificial plasma- prefix, but we're already using that in other plasma applets, so maybe it's too late to reverse course now) 1. URL Not OK Please use, URL: https://projects.kde.org/projects/kde/workspace/milou 2. SHOULD not use %make_install macro (not recommended by packaging guidelines... yet) I'd prefer: make install/fast DESTDIR=%{buildroot} -C %{_target_platform} over %make_install -C %{_target_platform} macros: NOT OK 3. SHOULD use %_kf5_qmldir macro replace %{_qt5_prefix}/qml/org/kde/milou with %{_kf5_qmldir}/org/kde/milou/ sources: OK b99660be2145dae3144e8e004c649ec6 milou-5.1.1.tar.xz licensing: OK scriptlets: OK
Naming: We are using kde-plasma- prefix for applets so I'm not sure right now what to use for milou. I also just realized that we already have kde-plasma-milou package so if you want to keep it we can discard this review and just update the current package. 1. Fixed 2. Fixed 3. Fixed Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-milou-5.1.1-1.fc21.src.rpm Description: A dedicated KDE search application built on top of Baloo Fedora Account System Username: jgrulich
Looks good, thanks... APPROVED. then we can retire kde-plasma-milou for f22+, I suppose for added safety you could also consider adding: Provides: kde-plasma-milou = %{version}=%{release}
New Package SCM Request ======================= Package Name: plasma-milou Short Description: A dedicated KDE search application built on top of Baloo Upstream URL: https://projects.kde.org/projects/kde/workspace/milou Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
Git done (by process-git-requests).