Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-systemsettings.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-systemsettings-5.1.1-1.fc21.src.rpm Description: KDE's System Settings application Fedora Account System Username: jgrulich Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8410657
naming: ok (mostly) 1. another pkg where I'm not fond of using an artificial plasma- prefix, SHOULD consider removing it. 2. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} -C %{_target_platform} over %make_install -C %{_target_platform} 3. MUST validate application .desktop file, add BuildRequires: desktop-file-utils and %check desktop-file-validate %{buildroot}%{_datadir}/applications/kdesystemsettings.desktop desktop-file-validate %{buildroot}%{_datadir}/applications/systemsettings.desktop 4. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML handbooks 5. SHOULD use better project url URL: https://projects.kde.org/projects/kde/workspace/systemsettings sources: ok bb382e4c5b97a4ed8c8e116567247a83 systemsettings-5.1.1.tar.xz license: ok
1. That's something I'm not sure with, having a package called just systemsettings in Fedora doesn't seem to be a good option. 2-5. Fixed Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-systemsettings.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-systemsettings-5.1.1-1.fc21.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8528049
looks good, APPROVED p.s. make sure to update changelog too when updating pkgs for reviews
New Package SCM Request ======================= Package Name: plasma-systemsettings Short Description: KDE's System Settings application Upstream URL: https://projects.kde.org/projects/kde/workspace/systemsettings Owners: @kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "@kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: plasma-systemsettings Short Description: KDE's System Settings application Upstream URL: https://projects.kde.org/projects/kde/workspace/systemsettings Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "group::kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: plasma-systemsettings Short Description: KDE's System Settings application Upstream URL: https://projects.kde.org/projects/kde/workspace/systemsettings Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
Git done (by process-git-requests).