Spec URL: https://jgrulich.fedorapeople.org/plasma5/powerdevil.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/powerdevil-5.1.1-1.fc21.src.rpm Description: Manages the power consumption settings of a Plasma Shell Fedora Account System Username: jgrulich
License should be marked as: %license COPYING I believe you can make better on %description :) I am missing destop-file-install: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Should %{_datadir}/doc/HTML/en/kcontrol/powerdevil be marked as %doc ? During build time: Error: No Package found for plasma-workspace-devel
No need for desktop-file-install, there are no .desktop files used for application menus (ie, nothing is installed under /usr/share/applications/...)
And, fwiw, using %license macro isn't documented in packaging guidelines, so I wouldn't go around recommending it's use... yet (unless you can provide references to work-in-progress packaging guidelines about it). and stuff under %_docdir (aka %_datadir/doc) is automatically marked as %doc these days too.
See https://fedorahosted.org/fpc/ticket/411 https://lists.fedoraproject.org/pipermail/packaging/2014-May/010157.html
Sure, guidelines are coming, but haven't landed yet. So, I'd urge that items that are not-yet-in-published guidelines to be considered review blockers. (Unless it is published already, in which case, giving references to it would be appreciated)
I think that came out wrong... :) to be clear, I mean that items not-yet-published in packaging guidelines should *not* be considered review blockers.
Added better description. Regarding the build error, plasma-workspace-devel is not pushed to a review yet, but will be soon. Spec URL: https://jgrulich.fedorapeople.org/plasma5/powerdevil.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/powerdevil-5.1.1-1.fc21.src.rpm Description: Manages the power consumption settings of a Plasma Shell Fedora Account System Username: jgrulich
naming: ok sources: ok 77b4c7c1b8978955333782221e9fae97 powerdevil-5.1.1.tar.xz license: ok 1. SHOULD use better project url, suggest: URL: https://projects.kde.org/projects/kde/workspace/powerdevil 2. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} ... over %make_install 3. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML handbooks 4. SHOULD consider -libs subpkg, to be multilib-friendly (so not entire powerdevil pkg gets multilib'd due to the included shlibs) 5. SHOULD drop unused (afaict) BuildRequires: chrpath Lots of should'd, but no must blockers, APPROVED.
New Package SCM Request ======================= Package Name: powerdevil Short Description: Manages the power consumption settings of a Plasma Shell Upstream URL: https://projects.kde.org/projects/kde/workspace/powerdevil Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC: kde-sig
WARNING: "kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: powerdevil Short Description: Manages the power consumption settings of a Plasma Shell Upstream URL: https://projects.kde.org/projects/kde/workspace/powerdevil Owners: @kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "@kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: powerdevil Short Description: Manages the power consumption settings of a Plasma Shell Upstream URL: https://projects.kde.org/projects/kde/workspace/powerdevil Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
WARNING: "group::kde-sig" is not a valid FAS account.
New Package SCM Request ======================= Package Name: powerdevil Short Description: Manages the power consumption settings of a Plasma Shell Upstream URL: https://projects.kde.org/projects/kde/workspace/powerdevil Owners: rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC:
Git done (by process-git-requests).
Hi Jan, FYI: The package powerdevil is not automatically installed with the rawhide update to plasma-5. Martin Kho