ADB and the Android platform tools are more than one year out of date in F21. I don't know if there is any particular reason for that but I'm having issues using ADB sideload with Android 5.0 which some people claim is caused by out of date ADB. If there is a reason for not updating the package so far or in the future, I would like to know it so I can move to a manual installation.
The reason why android-tools are so outdated is that they require android port of libselinux and I don't think it is good idea to ship it within fedora. I'll doublecheck if things have changed
Alright, thanks!
Created attachment 973247 [details] Patch to update android-tools to Lollipop 5.0.2 release - apply against Fedora git Here's a patch against android-tools git HEAD that will update it to the Lollipop 5.0.2 release (tag android-5.0.2_r1 in both core and extras). Obviously, you'll need to regenerate the core and extra tarballs from upstream git. I have added two patches, one to strip out selinux/android.h which seems to be unused by the code we compile (and therefore allows us to compile using the system selinux library), and the second to add in a missed header in f2fs_ioutils (no idea why it's missing; I'm assuming it has something to do with the difference between the android buildsystem and our own). I do have a srpm and F21 x86_64 rpm available at http://lesloueizeh.com/jdieter/android-tools and the srpm will have the necessary core and extras git checkouts.
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu99 -DADB_HOST=1 -DHAVE_FORKEXEC=1 -DHAVE_SYMLINKS -DHAVE_TERMIO_H -D_GNU_SOURCE -D_XOPEN_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_OFF64_T -DHAVE_SYS_UIO_H -I. -I../include -I../libsparse/include -I../mkbootimg -I../../extras/ext4_utils -I../../extras/f2fs_utils -c -o ext4_sb.o ../../extras/ext4_utils/ext4_sb.c gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu99 -DADB_HOST=1 -DHAVE_FORKEXEC=1 -DHAVE_SYMLINKS -DHAVE_TERMIO_H -D_GNU_SOURCE -D_XOPEN_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_OFF64_T -DHAVE_SYS_UIO_H -I. -I../include -I../libsparse/include -I../mkbootimg -I../../extras/ext4_utils -I../../extras/f2fs_utils -c -o f2fs_ioutils.o ../../extras/f2fs_utils/f2fs_ioutils.c ../../extras/f2fs_utils/f2fs_ioutils.c:46:21: fatal error: f2fs_fs.h: No such file or directory #include <f2fs_fs.h> ^ compilation terminated. It seems f2fs-tools-devel package doesn't include f2fs_fs.h I see it within kernel-devel but not sure how to use it. Maybe we should fill the bug on f2fs-tools package
Aww, flip. Yes, I've already rebuilt f2fs-tools to fix that, but then thought it wasn't necessary for f2fs_ioutils. I've created a new bug report against f2fs-tools at https://bugzilla.redhat.com/show_bug.cgi?id=1177397
Ok, we should be good to build and push this now.
Works well for me even without 0002-Add-missing-headers.patch
Great! I think the missing headers problem was hit when I was still trying to compile some of the other f2fs*.c files.
Thanks for building for Rawhide. Would you mind pushing to F21 and F20 as well, please?
android-tools-20141219git8393e50-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/android-tools-20141219git8393e50-2.fc21
Package android-tools-20141219git8393e50-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing android-tools-20141219git8393e50-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-0938/android-tools-20141219git8393e50-2.fc21 then log in and leave karma (feedback).
Couldn't get adb to work with Motorola Moto G 2014 with current Fedora 21 version, wasted one hour trying to get it working. Works OK with android-tools-20141219git8393e50-2.fc21.
Ivan, do you mind manually pushing this to stable? Thanks.
android-tools-20141219git8393e50-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.