Description of problem: When i create scalable app ,and scale up the app to insure the app's gear_uuid is in predictable gear uuid format, then do the gear upgrade the result is incomplete due to the failed gears. Version-Release number of selected component (if applicable): devenv_5367 How reproducible: always Steps to Reproduce: 1.Prepare data on latest devenv instance; 2.Run the command `oo-broker --non-interactive oo-admin-upgrade upgrade-node --ignore-cartridge-version --version 2.0.55` to do the node/gear migration. 3. Actual results: The upgrade was incomplete due to unprocessed or failed gears Expected results: The upgrade completed with no error. Additional info: "errors": [ "Upgrade failed with an unhandled exception: Cannot validate input uuid: value should match ^[a-zA-Z0-9]+$\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/base.rb:145:in `rescue in validate_input_argument'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/base.rb:126:in `validate_input_argument'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:194:in `block in validate_rpc_request'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:186:in `each'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:186:in `validate_rpc_request'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/client.rb:169:in `validate_request'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/client.rb:240:in `method_missing'\n/usr/sbin/oo-admin-upgrade:758:in `block (2 levels) in upgrade_gear'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1/lib/openshift/mcollective_application_container_proxy.rb:2440:in `rpc_exec'\n/usr/sbin/oo-admin-upgrade:757:in `block in upgrade_gear'\n/opt/rh/ruby193/root/usr/share/ruby/timeout.rb:69:in `timeout'\n/usr/sbin/oo-admin-upgrade:756:in `upgrade_gear'\n/usr/sbin/oo-admin-upgrade:635:in `block (2 levels) in upgrade_node_from_gear_queue_file'\n/usr/sbin/oo-admin-upgrade:633:in `each'\n/usr/sbin/oo-admin-upgrade:633:in `block in upgrade_node_from_gear_queue_file'\n/usr/sbin/oo-admin-upgrade:616:in `each_line'\n/usr/sbin/oo-admin-upgrade:616:in `upgrade_node_from_gear_queue_file'\n/usr/sbin/oo-admin-upgrade:1051:in `block in upgrade_from_file'\n/usr/sbin/oo-admin-upgrade:1008:in `with_upgrader'\n/usr/sbin/oo-admin-upgrade:1050:in `upgrade_from_file'\n/opt/rh/ruby193/root/usr/share/gems/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'\n/opt/rh/ruby193/root/usr/share/gems/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'\n/opt/rh/ruby193/root/usr/share/gems/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'\n/opt/rh/ruby193/root/usr/share/gems/gems/thor-0.1 8.1/lib/thor/base.rb:439:in `start'\n/usr/sbin/oo-admin-upgrade:1093:in `<main>'", "Failed upgrade after 2 tries" ]
Should be an easy fix to the ddl.
Actually... the DDL should already have been fixed two weeks before this was reported (https://github.com/openshift/origin-server/pull/6001/files#diff-4411662c8397e57b2d7e1844964cfbc2R510) so I don't understand why this is still referencing the old regex: "Upgrade failed with an unhandled exception: Cannot validate input uuid: value should match ^[a-zA-Z0-9]+$ I can confirm I see the same thing, though, while openshift.ddl appears to be correct. Still investigating.
Agent code was needlessly re-validating uuid with an outdated regex. https://github.com/openshift/origin-server/pull/6039
Should this be moved to ON_QA?
Yes... I apparently got confused.
Confirmed. On devenv_5392.