Bug 1176280 - UI no longer warns the user when leaving an edit session with changes by clicking on navigation tabs
Summary: UI no longer warns the user when leaving an edit session with changes by clic...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.4.0
Assignee: Dan Clarizio
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks: 1176281
TreeView+ depends on / blocked
 
Reported: 2014-12-19 23:41 UTC by Dan Clarizio
Modified: 2015-06-16 12:46 UTC (History)
5 users (show)

Fixed In Version: 5.4.0.0.11
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1176281 (view as bug list)
Environment:
Last Closed: 2015-06-16 12:46:35 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Dan Clarizio 2014-12-19 23:41:56 UTC
Description of problem:
When in an active edit and user has made changes, clicking on a navigation tab no longer warns the user that he will lose his changes.

Version-Release number of selected component (if applicable):
5.3.1

How reproducible:
Open an edit, make a change, click on a different nav tab

Actual results:
UI switches to that tab

Expected results:
UI should put up a warning box allowing the user to cancel or proceed

Additional info:
Introduced with this commit:
06c348f Eric Winchell at 10/2/13 10:40 AM (committed at 10/7/13 12:02 PM) Update navigation bar with dropdown hover state

Comment 2 CFME Bot 2014-12-22 17:40:57 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/fcf7ea023d0945d936108e05d057e89c5e04158e

commit fcf7ea023d0945d936108e05d057e89c5e04158e
Author:     Dan Clarizio <dclarizi@redh>
AuthorDate: Fri Dec 19 15:51:32 2014 -0800
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri Dec 19 15:52:41 2014 -0800

    Add miqCheckForChanges calls back into navigation tab links
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1176280
    https://bugzilla.redhat.com/show_bug.cgi?id=1176281

 .../views/layouts/_page_header_navbar.html.haml    | 174 ++++++++++++++-------
 1 file changed, 116 insertions(+), 58 deletions(-)

Comment 3 CFME Bot 2014-12-22 18:35:57 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dd32227662f606ae982354dc78b0cad307354980

commit dd32227662f606ae982354dc78b0cad307354980
Author:     Dan Clarizio <dclarizi@redh>
AuthorDate: Mon Dec 22 10:30:58 2014 -0800
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Dec 22 10:30:58 2014 -0800

    Add miqCheckForChanges calls back into navigation tab links
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1176280
    https://bugzilla.redhat.com/show_bug.cgi?id=1176281
    (cherry picked from commit fcf7ea0)

 .../views/layouts/_page_header_navbar.html.haml    | 200 ++++++++++++++-------
 1 file changed, 133 insertions(+), 67 deletions(-)

Comment 4 Aziza Karol 2015-02-05 10:49:54 UTC
UI pops up a warning box allowing the user to cancel or proceed

upstream verified:
master.20150205053905_aa6d1cd

Comment 6 Shveta 2015-03-25 22:00:12 UTC
Verified in 5.4.0.0.13.20150319164909_f011a66

Comment 8 errata-xmlrpc 2015-06-16 12:46:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.