Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1176393

Summary: marker: inode_path is being called on the inodes not yet linked
Product: [Community] GlusterFS Reporter: Raghavendra Bhat <rabhat>
Component: quotaAssignee: Raghavendra Bhat <rabhat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs, iesool, ndevos, vmallika
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1218936 (view as bug list) Environment:
Last Closed: 2015-05-14 17:28:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1138646, 1174170, 1174247, 1174250, 1189792, 1218936    

Description Raghavendra Bhat 2014-12-21 09:21:55 UTC
Description of problem:

in marker_readdirp_cbk inode_path is being called on the inodes that are not yet linked to the inode table. If glusterfs was built with DDEBUG, then it leads to process being asserted. Otherwise, building loc for xattr operation fails and might cause problems.

        list_for_each_entry (entry, &entries->list, list) {
		if ((strcmp (entry->d_name, ".") == 0) ||
                    (strcmp (entry->d_name, "..") == 0))
    	                continue;

                ret = marker_inode_loc_fill (entry->inode,
                                             entry->d_name, &loc);
                if (ret) {
                        gf_log (this->name, GF_LOG_WARNING, "Couln't build "
                                "loc for %s/%s",
                                uuid_utoa (local->loc.inode->gfid),
                                entry->d_name);
	                continue;
                }

	        mq_xattr_state (this, &loc, entry->dict, entry->d_stat);

		loc_wipe (&loc);
	}


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-12-21 16:33:20 UTC
REVIEW: http://review.gluster.org/9320 (features/marker: do not call inode_path on the inode not yet linked) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Lalatendu Mohanty 2015-01-21 05:56:52 UTC
*** Bug 1182514 has been marked as a duplicate of this bug. ***

Comment 3 Anand Avati 2015-01-21 08:43:10 UTC
REVIEW: http://review.gluster.org/9320 (features/marker: do not call inode_path on the inode not yet linked) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 4 Niels de Vos 2015-01-23 11:17:53 UTC
*** Bug 1174247 has been marked as a duplicate of this bug. ***

Comment 5 Anand Avati 2015-01-24 05:59:34 UTC
COMMIT: http://review.gluster.org/9320 committed in master by Raghavendra G (rgowdapp) 
------
commit becdb76238c45ebe3edc967376f4aee87c0cb6e3
Author: Raghavendra Bhat <raghavendra>
Date:   Sun Dec 21 22:01:03 2014 +0530

    features/marker: do not call inode_path on the inode not yet linked
    
    * in readdirp callbak marker is calling inode_path on the inodes that
      are not yet linked to the inode table.
    
    Change-Id: I7f5db29c6a7e778272044f60f8e73c60574df3a9
    BUG: 1176393
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/9320
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 6 Niels de Vos 2015-05-14 17:28:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:35:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:38:08 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:45:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user