Bug 1176420 - RFE: Help should be patched to use right command name
Summary: RFE: Help should be patched to use right command name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ninja-build
Version: rawhide
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Ben Boeckel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1176277
TreeView+ depends on / blocked
 
Reported: 2014-12-21 15:58 UTC by Raphael Groner
Modified: 2016-07-24 03:19 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-24 03:19:07 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
ninja-build for help output (418 bytes, patch)
2014-12-21 16:10 UTC, Raphael Groner 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1166135 0 unspecified CLOSED RFE: Please rename "ninja-build" executable to just "ninja". 2021-02-22 00:41:40 UTC

Internal Links: 1166135

Description Raphael Groner 2014-12-21 15:58:33 UTC 
Description of problem:
Help should be patched to use right command name: In Fedora, 'ninja-build' is used for both name the package and the command, instead of just 'ninja' as in the help output. So either rename package only or patch the help also. Hmm, there is the ninja IRC client that conflicts of course.

Version-Release number of selected component (if applicable):
ninja-build-1.4.0-1.fc20.x86_64
(Verified on Fedora 20, but I think this is also for Rawhide with v1.5.x)

How reproducible:
yes

Steps to Reproduce:
1. yum install -y ninja-build
2. ninja-build --help
3.

Actual results:
usage: ninja [options] [targets...]

Expected results:
usage: ninja-build [options] [targets...]
-or- do not rename command and just use 'ninja' as the original name.

Additional info:
A patch should be easy to do.
Comment 1 Raphael Groner 2014-12-21 15:59:23 UTC 
CC to maintainer of ninja IRC.
Comment 2 Raphael Groner 2014-12-21 16:10:11 UTC 
Created attachment 971746 [details]
ninja-build for help output
Comment 3 Adrian Reber 2014-12-21 16:47:46 UTC 
This is somehow related to #1166135
Comment 4 Raphael Groner 2014-12-23 09:52:35 UTC 
(In reply to Raphael Groner from comment #2)
> Created attachment 971746 [details]
> ninja-build for help output

Hmm, a good patch could be more tricky than expected:

Do not trust argv[0], http://www.lst.de/~okir/blackhats/node40.html
Comment 5 Jaroslav Reznik 2015-03-03 16:38:53 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Comment 6 Raphael Groner 2015-03-03 21:14:36 UTC 
Reverting back to rawhide. This is an issue with packaging. The binary name gets modified intentionally in spec file and independently from any version.
Comment 7 Raphael Groner 2015-03-31 16:13:27 UTC 
ninja (jabber client) is orphaned and upstream of it seems to be dead.
Therefore, maybe consider to rename ninja-build back into ninja.
Comment 8 Christopher Meng 2015-04-01 04:47:51 UTC 
(In reply to Raphael Groner from comment #7)
> ninja (jabber client) is orphaned and upstream of it seems to be dead.
> Therefore, maybe consider to rename ninja-build back into ninja.

Yes, as docker-io has been renamed to docker finally ;)
Comment 9 Raphael Groner 2015-11-15 16:13:44 UTC 
Ping, any news here?
Comment 10 Ben Boeckel 2015-11-16 23:04:20 UTC 
I have a patch to update the binary name, testing it with a local build now. As for renaming it, see Bug #1166135.
Comment 11 Ben Boeckel 2016-07-24 03:19:07 UTC 
Was fixed in 1.6.0-3.
Note You need to log in before you can comment on or make changes to this bug.