Description of problem: This bug is to track small, incremental changes in glusterd code base to remove cruft and improve readability. Version-Release number of selected component (if applicable): How reproducible: N/A Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/9315 (glusterd: fix unix domain notify fn) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)
REVIEW: http://review.gluster.org/9313 (glusterd: Move statedump utils into a new file.) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)
REVIEW: http://review.gluster.org/9292 (glusterd: check_volume_exists should query in-memory representation) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)
REVIEW: http://review.gluster.org/9288 (glusterd: separate realloc from readlines logic) posted (#3) for review on master by Krishnan Parthasarathi (kparthas)
REVIEW: http://review.gluster.org/9273 (glusterd: handle snap bricks at the right layer) posted (#3) for review on master by Krishnan Parthasarathi (kparthas)
COMMIT: http://review.gluster.org/9315 committed in master by Kaushal M (kaushal) ------ commit f3df93783d8c817722e086b14b97fa6bc9d0fce8 Author: Krishnan Parthasarathi <kparthas> Date: Fri Dec 19 17:07:50 2014 +0530 glusterd: fix unix domain notify fn ... and unlink the 'right' socket file Change-Id: Id12ee8c622914555b7933104e13b43b3b31b5d19 BUG: 1176770 Signed-off-by: Krishnan Parthasarathi <kparthas> Reviewed-on: http://review.gluster.org/9315 Reviewed-by: Kaushal M <kaushal> Tested-by: Kaushal M <kaushal>
COMMIT: http://review.gluster.org/9292 committed in master by Krishnan Parthasarathi (kparthas) ------ commit f7a8bd08c80a33a9e2459b47e203a8bc841abc54 Author: Krishnan Parthasarathi <kparthas> Date: Thu Dec 18 09:18:12 2014 +0530 glusterd: check_volume_exists should query in-memory representation ... instead of consulting the on-disk data directory. There is no reason why the on-disk is more accurate than the in-memory representation. In fact, it is the other way around when a node is reconciling volume/cluster configuration with the rest of the cluster. Change-Id: I786823efdf1d0f6b9e6fcdb72d51e5227c399ce1 BUG: 1176770 Signed-off-by: Krishnan Parthasarathi <kparthas> Reviewed-on: http://review.gluster.org/9292 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj>
COMMIT: http://review.gluster.org/9313 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 41e0e325aa7733285733fb00230fdaafdc80c25a Author: Krishnan Parthasarathi <kparthas> Date: Fri Dec 19 16:36:25 2014 +0530 glusterd: Move statedump utils into a new file. Change-Id: I1bf26c9d294e95f7b82cfc7a96f9d5575f5e0362 BUG: 1176770 Signed-off-by: Krishnan Parthasarathi <kparthas> Reviewed-on: http://review.gluster.org/9313 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj>
REVIEW: http://review.gluster.org/9391 (glusterd: Refactor glusterd-utils.c) posted (#1) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/9391 (glusterd: Refactor glusterd-utils.c) posted (#2) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/9391 (glusterd: Refactor glusterd-utils.c) posted (#3) for review on master by Avra Sengupta (asengupt)
REVIEW: http://review.gluster.org/9391 (glusterd: Refactor glusterd-utils.c) posted (#4) for review on master by Avra Sengupta (asengupt)
COMMIT: http://review.gluster.org/9391 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 4056ed598f642d2d23a65b79495b0247d84db2f4 Author: Avra Sengupta <asengupt> Date: Tue Jan 6 07:40:32 2015 +0000 glusterd: Refactor glusterd-utils.c Refactor glusterd-utils.c to create glusterd-snapshot-utils.c consisting of all snapshot utility functions. Change-Id: Id9823a2aec9b115f9c040c9940f288d4fe753d9b BUG: 1176770 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/9391 Reviewed-by: Kaushal M <kaushal> Reviewed-by: Rajesh Joseph <rjoseph> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/9423 (glusterd: glusterd socket files should reside in /var/run/glusterd) posted (#1) for review on master by Atin Mukherjee (amukherj)
REVIEW: http://review.gluster.org/9423 (glusterd: glusterd socket files should reside in /var/run/gluster) posted (#2) for review on master by Atin Mukherjee (amukherj)
We'd like to have this carried forward in GD2 development phase and keep this point in my mind that code should be as modular as possible. There is no near future plan for a refactoring of GlusterD 1.0 and hence closing this bug.