Bug 1177132 - glusterd: when there is loss in quorum then it should block all operation
Summary: glusterd: when there is loss in quorum then it should block all operation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Gaurav Kumar Garg
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1177134
TreeView+ depends on / blocked
 
Reported: 2014-12-24 11:03 UTC by Gaurav Kumar Garg
Modified: 2016-06-05 23:38 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of:
: 1177134 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:28:46 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Gaurav Kumar Garg 2014-12-24 11:03:31 UTC
Description of problem:
when there is loss in quorum then it should block all the operation. currently can able to do few operation for eg. volume set, add-brick, remove-brick when there is loss in quorum. 

Version-Release number of selected component (if applicable):
Mainline

How reproducible:
Almost always

Steps to Reproduce:
1. Create distribute volume with two node in cluster.
2. do gluster volume set 
    cluster.server-quorum-type: server
3. set quorum ratio
    cluster.server-quorum-ratio: 51
4. bring down any one of the node in cluster
2. perform add-brick, volume set, remove-brick operation in node which is currently active.
3. Its allowing these operation even there is loss in quorum.

Actual results:

Its successfully allowing these operation even if there is loss in quorum

Expected results:

It should give error and should not allow any operation when quorum is not met.

Comment 1 Anand Avati 2014-12-26 05:41:01 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd sync-op framework) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2014-12-26 10:22:37 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd sync-op framework) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2014-12-29 05:23:58 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd sync-op framework) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2014-12-30 06:08:17 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd syncop framework) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-01-08 06:27:40 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd syncop framework) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-01-12 05:25:17 UTC
REVIEW: http://review.gluster.org/9422 (glusterd: quorum calculation should happen on global peer_list) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2015-01-13 04:08:08 UTC
COMMIT: http://review.gluster.org/9422 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 9d37406b59fc33940c8e4e925ef9803b2d9b6507
Author: Atin Mukherjee <amukherj>
Date:   Fri Jan 9 10:15:04 2015 +0530

    glusterd: quorum calculation should happen on global peer_list
    
    Apart from snapshot, for all other transactions quorum should be calculated on
    global peer list.
    
    Change-Id: I30bacdb6521b0c6fd762be84d3b7aa40d00aacc4
    BUG: 1177132
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/9422
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 8 Anand Avati 2015-01-13 05:18:48 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd syncop framework) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Anand Avati 2015-01-15 07:55:43 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd syncop framework) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)

Comment 10 Anand Avati 2015-01-16 07:08:21 UTC
REVIEW: http://review.gluster.org/9349 (glusterd: quorum validatation in glusterd syncop framework) posted (#8) for review on master by Gaurav Kumar Garg (ggarg)

Comment 11 Anand Avati 2015-01-21 06:38:42 UTC
COMMIT: http://review.gluster.org/9349 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 30ad195d49b971a5389d37c9d9a3583186f3d54a
Author: GauravKumarGarg <ggarg>
Date:   Wed Dec 24 16:39:03 2014 +0530

    glusterd: quorum validatation in glusterd syncop framework
    
    Previously glusterd was not checking quorum validation in syncop framework.
    So when there is loss in quorum then few operation (for eg. add-brick,
    remove-brick, volume set) which is based on syncop framework passed
    successfully with out doing quorum validation check.
    
    With this change it will do quorum validation in syncop framework and it will
    block all operation (except volume set <quorum options> and "volume reset all"
    commands) when there is loss in quorum.
    
    Change-Id: I4c2ef16728d55c98a228bb86795023d9c1f4e9fb
    BUG: 1177132
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/9349
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 12 Niels de Vos 2015-05-14 17:28:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 13 Niels de Vos 2015-05-14 17:35:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 14 Niels de Vos 2015-05-14 17:38:09 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 15 Niels de Vos 2015-05-14 17:45:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.