Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
when we create activation-key, the description field accepts greater than 1000 characters. This is happening while creating as well as updating the description. Earlier the limit was set for 1000 characters. Now user can add any number of characters in description field. Version: nightly * apr-util-ldap-1.3.9-3.el6_0.1.x86_64 * candlepin-0.9.37-1.el6.noarch * candlepin-common-1.0.17-1.el6.noarch * candlepin-selinux-0.9.37-1.el6.noarch * candlepin-tomcat6-0.9.37-1.el6.noarch * elasticsearch-0.90.10-7.el6.noarch * foreman-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-compute-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-gce-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-libvirt-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-ovirt-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-postgresql-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-proxy-1.8.0-0.develop.201412171625git51c455b.el6.noarch * foreman-release-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * foreman-selinux-1.8.0-0.develop.201412151103gite2863e4.el6.noarch * foreman-vmware-1.8.0-0.develop.201412181705git9e844ba.el6.noarch * katello-2.1.0-1.201411061509gitb0b8f43.el6.noarch * katello-certs-tools-2.0.1-1.el6.noarch * katello-default-ca-1.0-1.noarch * katello-installer-2.1.0-1.201412180333gitb02e8f2.el6.noarch * katello-installer-base-2.1.0-1.201412180333gitb02e8f2.el6.noarch * katello-repos-2.1.1-1.el6.noarch * katello-server-ca-1.0-1.noarch * openldap-2.4.39-8.el6.x86_64 * pulp-docker-plugins-0.2.1-0.2.beta.el6.noarch * pulp-katello-0.3-3.el6.noarch * pulp-nodes-common-2.5.0-0.7.beta.el6.noarch * pulp-nodes-parent-2.5.0-0.7.beta.el6.noarch * pulp-puppet-plugins-2.5.0-0.7.beta.el6.noarch * pulp-puppet-tools-2.5.0-0.7.beta.el6.noarch * pulp-rpm-plugins-2.5.0-0.7.beta.el6.noarch * pulp-selinux-2.5.0-0.7.beta.el6.noarch * pulp-server-2.5.0-0.7.beta.el6.noarch * python-ldap-2.3.10-1.el6.x86_64 * ruby193-rubygem-ldap_fluff-0.3.3-1.el6.noarch * ruby193-rubygem-net-ldap-0.10.0-1.el6.noarch * ruby193-rubygem-runcible-1.3.0-1.el6.noarch * rubygem-hammer_cli-0.1.4-1.el6.noarch * rubygem-hammer_cli_foreman-0.1.4-1.el6.noarch * rubygem-hammer_cli_foreman_bootdisk-0.1.2-1.el6.noarch * rubygem-hammer_cli_foreman_tasks-0.0.3-2.201409091410gitc96619d.git.0.37f3704.el6.noarch * rubygem-hammer_cli_import-0.10.4-1.el6.noarch * rubygem-hammer_cli_katello-0.0.6-1.201412181307git280ed45.git.0.52b14f3.el6.noarch Steps to reproduce: 1. Go TO contents--> activation_key 2. New key form -> enter description greater than of 1000 chars Actual result: Description accepts more than 1000 characters while creating/updating the key. Earlier the limit was set to 1000 char, now no limit set on this. Expected result: validation error should be raised once the limit exceeds 1000 char
Created attachment 972792 [details] description field accepts more than 1000 char while creating and updating activation key
Since this issue was entered in Red Hat Bugzilla, the release flag has been set to ? to ensure that it is properly evaluated for this release.
Created redmine issue http://projects.theforeman.org/issues/9344 from this bug
So, we now do not need the 1000 character limit, as we are validating lengths from the database itself. Is there any additional argument as to why we should limit the description field?
Hi Christine, we have automation around this issue. So earlier a limit of 1000 char was set on description field. So this bz is around the existing behavior. Now user can add long description for activation-key. And there is no limit set for this field for UI. If we are planning to validate field length at database level then it should be consistent around all features. For ex: for content-view description field 256 char limit is set.
I agree that description lengths should be consistent, but there shouldn't be consistently a 256 limit. Please file a bug for any object that has a limit of 256, and I can confirm that content views are such a case. Given this, I believe the above, I do believe this bug should be closed. Please do so, unless you disagree.
I am going to repurpose this bug to make all description fields consistent across Katello. We should also remove description from table columns to avoid having a 1000+ characters taking up a small field in a table.
This isn't high priority enough for 6.1, moving to 6.2
Upstream bug assigned to cfouant
Ok, with these two PRs every description field in foreman and katello is a text field which is pretty much unlimited in PostgreSQL. https://github.com/theforeman/foreman/pull/2155 https://github.com/Katello/katello/pull/5005
*** This bug is verified in upstream. This fix should eventually land in future downstream builds *** Version Tested: # rpm -qa | grep foreman foreman-proxy-1.11.0-0.develop.201510201341git00875b3.el7.noarch foreman-selinux-1.11.0-0.develop.201510071426git6234447.el7.noarch tfm-rubygem-hammer_cli_foreman_bootdisk-0.1.3-3.el7.noarch tfm-rubygem-foreman_docker-1.4.1-2.fm1_10.el7.noarch foreman-debug-1.11.0-0.develop.201510271601git4e08a71.el7.noarch foreman-compute-1.11.0-0.develop.201510271601git4e08a71.el7.noarch foreman-release-scl-1-1.el7.x86_64 foreman-gce-1.11.0-0.develop.201510271601git4e08a71.el7.noarch tfm-rubygem-foreman_gutterball-0.0.1-3.el7.noarch hp-z600-01.rhts.eng.bos.redhat.com-foreman-client-1.0-1.noarch hp-z600-01.rhts.eng.bos.redhat.com-foreman-proxy-client-1.0-1.noarch tfm-rubygem-foreman_discovery-4.1.2-1.fm1_11.el7.noarch foreman-vmware-1.11.0-0.develop.201510271601git4e08a71.el7.noarch tfm-rubygem-foreman_hooks-0.3.9-1.el7.noarch tfm-rubygem-foreman-tasks-0.7.6-1.fm1_10.el7.noarch tfm-rubygem-hammer_cli_foreman_tasks-0.0.8-1.el7.noarch hp-z600-01.rhts.eng.bos.redhat.com-foreman-proxy-1.0-1.noarch foreman-ovirt-1.11.0-0.develop.201510271601git4e08a71.el7.noarch foreman-1.11.0-0.develop.201510271601git4e08a71.el7.noarch tfm-rubygem-hammer_cli_foreman_docker-0.0.3-4.el7.noarch foreman-release-1.11.0-0.develop.201510271601git4e08a71.el7.noarch foreman-libvirt-1.11.0-0.develop.201510271601git4e08a71.el7.noarch foreman-postgresql-1.11.0-0.develop.201510271601git4e08a71.el7.noarch tfm-rubygem-hammer_cli_foreman-0.4.0-1.201510201150gitab068d9.el7.noarch tfm-rubygem-foreman_bootdisk-6.0.0-2.fm1_10.el7.noarch steps: 1. Go TO contents--> activation_key 2. New key form -> enter description greater than of 1000 chars validation error is raised once the limit exceeds 1000 char
(In reply to Christine Fouant from comment #7) > So, we now do not need the 1000 character limit, as we are validating > lengths from the database itself. Is there any additional argument as to why > we should limit the description field? uhm, how about the UI? The browser goes crazy with 7MB-worth description text :) Also, isn't there a size restriction for a HTTP request?
Not sure what was verified in that defect, but we don't have any limitation for description field, so gonna to remove corresponding test automation cases
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1500