Description of problem: Plugged in a Firefox OS device. I received some notifications about an inability to mount an MTP device. The notification did not indicate from which program it originated. Then I was informed of the ModemManager crash by ABRT. Version-Release number of selected component: ModemManager-1.4.0-1.fc21 Additional info: reporter: libreport-2.3.0 backtrace_rating: 4 cmdline: /usr/sbin/ModemManager crash_function: __strcmp_sse2_unaligned executable: /usr/sbin/ModemManager kernel: 3.17.7-300.fc21.x86_64 runlevel: N 5 type: CCpp uid: 0 Truncated backtrace: Thread no. 1 (9 frames) #0 __strcmp_sse2_unaligned at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:29 #1 g_str_equal at ghash.c:1776 #2 mm_plugin_supports_port at mm-plugin.c:711 #3 port_probe_context_step at mm-plugin-manager.c:587 #4 g_cclosure_marshal_VOID__OBJECTv at gmarshal.c:1312 #5 _g_closure_invoke_va at gclosure.c:831 #8 mm_device_grab_port at mm-device.c:328 #9 device_added at mm-base-manager.c:347 #14 monitor_event at /lib64/libgudev-1.0.so.0
Created attachment 974385 [details] File: backtrace
Created attachment 974386 [details] File: cgroup
Created attachment 974387 [details] File: core_backtrace
Created attachment 974388 [details] File: dso_list
Created attachment 974389 [details] File: environ
Created attachment 974390 [details] File: exploitable
Created attachment 974391 [details] File: limits
Created attachment 974392 [details] File: maps
Created attachment 974393 [details] File: open_fds
Created attachment 974394 [details] File: proc_pid_status
I think this is likely caused by glib API misuse. The crash origin is: g_str_equal (mm_device_utils_get_port_driver (port), "qmi_wwan") mm_device_utils_get_port_driver() is apparently intended to return a NULL-terminated string and this call is intended to compare the two strings. However, we can read in the glib documentation that g_str_equal(): "... is primarily meant as a hash table comparison function. For a general-purpose, NULL-safe string comparison function, see g_strcmp0()." And as it turns out, mm_device_utils_get_port_driver() can in fact return NULL. So it seems to me this bug can be fixed simply by substituting the calls to g_str_equal() with g_strcmp0(), taking care to compare the result of the latter to zero for equality.
Created attachment 974406 [details] Fix As described above. I rebuilt the ModemManager rpms with this patch and with them installed I don't receive notifications about ModemManager crashing when I plug the device in.
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.